Skip to content

don't call .item in onehot for XLA #127335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

don't call .item in onehot for XLA #127335

wants to merge 2 commits into from

Conversation

JackCaoG
Copy link
Collaborator

We found that nn.function.one_hot will cause a graph break due to the item call in the native implementation.

cc @alanwaketan

@JackCaoG JackCaoG requested review from bdhirsh and ezyang May 28, 2024 20:46
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 28, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127335

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 2d72718 with merge base a63310e (image):

NEW FAILURE - The following job has failed:

  • pull / linux-focal-cuda12.4-py3.10-gcc9 / build (gh)
    /var/lib/jenkins/workspace/aten/src/ATen/cuda/CUDASparseDescriptors.h:119:68: error: ‘cusparseStatus_t cusparseCreateBsrsm2Info(bsrsm2Info**)’ is deprecated: The routine will be removed in the next major release [-Werror=deprecated-declarations]

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

  • pull / linux-focal-cuda12.4-py3.10-gcc9-sm86 / build (gh) (#127104)
    /var/lib/jenkins/workspace/aten/src/ATen/cuda/CUDASparseDescriptors.h:119:68: error: ‘cusparseStatus_t cusparseCreateBsrsm2Info(bsrsm2Info**)’ is deprecated: The routine will be removed in the next major release [-Werror=deprecated-declarations]

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@JackCaoG JackCaoG mentioned this pull request May 28, 2024
Merged
@JackCaoG
Copy link
Collaborator Author

Ah.. I need to raise that error on the XLA end.. let me update my xla pr..

@pytorch-bot pytorch-bot bot added the release notes: nn release notes category label May 29, 2024
@JackCaoG
Copy link
Collaborator Author

test error doesn't seems relevant.

@JackCaoG
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 29, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@JackCaoG
Copy link
Collaborator Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 3 checks: pull / linux-focal-cuda12.4-py3.10-gcc9 / build, pull / linux-focal-cuda12.4-py3.10-gcc9-sm86 / build, trunk / win-vs2019-cpu-py3 / test (default, 1, 3, windows.4xlarge.nonephemeral)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorch-bot bot pushed a commit that referenced this pull request May 30, 2024
@JackCaoG @Aidyn-A
don't call .item in onehot for XLA (#127335)
5e00348 
We found that `nn.function.one_hot` will cause a graph break due to the item call in the native implementation.

Pull Request resolved: #127335
Approved by: https://github.com/ezyang
@github-actions github-actions bot deleted the JackCaoG/one_hot_item_xla branch June 29, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: nn release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JackCaoG @pytorchmergebot @ezyang @pytorchbot