[dtensor][be] added checksAssert function and refactored test cases #127356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127356
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit b6a88cc with merge base b36e390 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
oncall: distributed
sinhaanshul
added
the
better-engineering
sinhaanshul
requested review from
XilunWu,
tianyu-l,
wanchaol,
wz337 and
yifuwang
sinhaanshul
changed the title
XilunWu
approved these changes
May 29, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorch-bot bot
pushed a commit
that referenced
this pull request
May 30, 2024
…127356) **Summary** Added c10d checksAsserts functions to reduce written lines of code and refactored test cases. Merged one test case into another. **Test Plan** pytest test/distributed/_tensor/debug/test_comm_mode.py Pull Request resolved: #127356 Approved by: https://github.com/XilunWu ghstack dependencies: #127025, #127029, #127040, #127134, #127334
bigfootjon
pushed a commit
that referenced
this pull request
Jun 5, 2024
…127356) **Summary** Added c10d checksAsserts functions to reduce written lines of code and refactored test cases. Merged one test case into another. **Test Plan** pytest test/distributed/_tensor/debug/test_comm_mode.py Pull Request resolved: #127356 Approved by: https://github.com/XilunWu ghstack dependencies: #127025, #127029, #127040, #127134, #127334 (cherry picked from commit 15cc9f2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary
Added c10d checksAsserts functions to reduce written lines of code and refactored test cases. Merged one test case into another.
Test Plan
pytest test/distributed/_tensor/debug/test_comm_mode.py
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k