Skip to content

Conversation

iamzainhuda
Copy link
Contributor

@iamzainhuda iamzainhuda commented May 30, 2024

Copy link

pytorch-bot bot commented May 30, 2024

This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @kittenzcuddler43, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team.

@pytorch-bot pytorch-bot bot added module: distributed_checkpoint oncall: distributed Add this issue/PR to distributed oncall triage queue labels May 30, 2024
Copy link

pytorch-bot bot commented May 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127565

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit d068bfe with merge base 846f79e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57983752

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57983752

Copy link
Contributor

@wz337 wz337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing it!

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 30, 2024
@facebook-github-bot
Copy link
Contributor

@kittenzcuddler43 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57983752

@facebook-github-bot
Copy link
Contributor

@kittenzcuddler43 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary:
tsia


Test Plan:
sandcastle





cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k LucasLLC

Reviewed By: wz337

Differential Revision: D57983752

Pulled By: kittenzcuddler43
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57983752

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@iamzainhuda iamzainhuda added the topic: not user facing topic category label May 31, 2024
@iamzainhuda
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: GraphQL query
fragment PRCheckSuites on CheckSuiteConnection {
edges {
node {
app {
name
databaseId
}
workflowRun {
workflow {
name
}
databaseId
url
}
checkRuns(first: 50) {
nodes {
name
conclusion
detailsUrl
databaseId
title
summary
}
pageInfo {
endCursor
hasNextPage
}
}
conclusion
}
cursor
}
pageInfo {
hasNextPage
}
}

query ($owner: String!, $name: String!, $number: Int!, $cursor: String!) {
repository(name: $name, owner: $owner) {
pullRequest(number: $number) {
commits(last: 1) {
nodes {
commit {
oid
checkSuites(first: 10, after: $cursor) {
...PRCheckSuites
}
}
}
}
}
}
}
, args {'name': 'pytorch', 'owner': 'pytorch', 'number': 127565, 'cursor': 'Y3Vyc29yOnYyOpHPAAAABaxTDxg='} failed: [{'message': 'Something went wrong while executing your query. Please include 4804:2E5024:83404E:EEEF09:6659E5A5 when reporting this issue.'}]

Details for Dev Infra team Raised by workflow job

@iamzainhuda
Copy link
Contributor Author

@pytorchbot merge -f 'Minor changes to spelling.'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

bigfootjon pushed a commit that referenced this pull request Jun 5, 2024
Summary: tsia

Test Plan: sandcastle

Differential Revision: D57983752

Pull Request resolved: #127565
Approved by: https://github.com/wz337, https://github.com/fegin

(cherry picked from commit a010fa9)
petrex pushed a commit to petrex/pytorch that referenced this pull request Jun 5, 2024
Summary: tsia

Test Plan: sandcastle

Differential Revision: D57983752

Pull Request resolved: pytorch#127565
Approved by: https://github.com/wz337, https://github.com/fegin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants