use TypeMeta instead of ScalarType in TensorOptions #12768
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D10419671 Differential Version: 60878909
This was referenced Oct 17, 2018
Differential Revision: D10419671 Differential Version: 61134806
ezyang
reviewed
Oct 22, 2018
aten/src/ATen/Context.cpp
Outdated
| TypeExtendedInterface& getType(TensorOptions options) { | ||
| return globalContext().getType( | ||
| options.backend(), options.dtype(), options.is_variable()); | ||
| options.backend(), dataTypeToScalarType(options.dtype().id()), options.is_variable()); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Oct 22, 2018
| } | ||
| } | ||
|
|
||
| void set_dtype(optional<ScalarType> dtype) & noexcept { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Oct 22, 2018
| return TensorOptions().dtype(dtype); | ||
| } | ||
|
|
||
| inline TensorOptions dtype(ScalarType dtype) { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Oct 22, 2018
aten/src/ATen/cudnn/Descriptors.h
Outdated
| AT_CUDNN_CHECK(cudnnDropoutGetStatesSize(handle, &state_size)); | ||
| AT_ASSERT(options.device().type() == kCUDA); | ||
| AT_ASSERT(options.dtype() == kByte); | ||
| AT_ASSERT(dataTypeToScalarType(options.dtype().id()) == kByte); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Oct 22, 2018
| options); | ||
| AT_CHECK( | ||
| at::isFloatingType(options.dtype()), | ||
| at::isFloatingType(dataTypeToScalarType(options.dtype().id())), |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
approved these changes
Oct 22, 2018
added 6 commits
October 22, 2018 15:47
Differential Revision: D10419671 Differential Version: 61337004
Differential Revision: D10419671 Differential Version: 61345557
Differential Revision: D10419671 Differential Version: 61438577
Differential Revision: D10419671 Differential Version: 61590771
Differential Revision: D10419671 Differential Version: 61603924
Differential Revision: D10419671 Differential Version: 61616762
added 2 commits
October 24, 2018 21:46
Differential Revision: D10419671 Differential Version: 61622039
Differential Revision: D10419671 Differential Version: 61622526
ezyang
reviewed
Oct 25, 2018
|
|
||
| /// Constructs a `TensorOptions` object with the given dtype. | ||
| /// legacy constructor to support ScalarType | ||
| /* implicit */ TensorOptions(ScalarType dtype) : TensorOptions() { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
added 4 commits
October 25, 2018 11:51
Differential Revision: D10419671 Differential Version: 61681127
Differential Revision: D10419671 Differential Version: 61685404
Differential Revision: D10419671 Differential Version: 61727366
Differential Revision: D10419671 Differential Version: 61759285
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 26, 2018
Summary: Pull Request resolved: pytorch/pytorch#12768 Note: DefaultTensorOptions no longer fits in 64-bits. I kept functions that take ScalarType as input to minimize changes for now. Reviewed By: ezyang Differential Revision: D10419671 fbshipit-source-id: 9cc8c5982fde9ff243e03d55c0c52c2aa2c7efd8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #12766 Change return type of Tensor::dtype() from ScalarType to TypeMeta 💚
:white_circle: #12767 reduce Device to 32bits 💚
:black_circle: #12768 use TypeMeta instead of ScalarType in TensorOptions 💚
Note: DefaultTensorOptions no longer fits in 64-bits.
I kept functions that take ScalarType as input to minimize changes for now.
Differential Revision: D10419671