Skip to content

[export] Remove replace_sym_size_ops_pass #128443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[export] Remove replace_sym_size_ops_pass #128443

wants to merge 1 commit into from

Conversation

zhxchen17
Copy link
Contributor

Summary: Not needed anymore.

Test Plan: CI

Differential Revision: D58429458

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 11, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128443

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit be25d18 with merge base 3c971d2 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58429458

@zhxchen17 zhxchen17 added the topic: not user facing topic category label Jun 12, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58429458

@zhxchen17 @facebook-github-bot
[export] Remove replace_sym_size_ops_pass (pytorch#128443)
be25d18 
Summary:
Pull Request resolved: pytorch#128443

Not needed anymore.

Test Plan: CI

Reviewed By: ydwu4

Differential Revision: D58429458
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58429458

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 12, 2024
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

TharinduRusira pushed a commit to TharinduRusira/pytorch that referenced this pull request Jun 14, 2024
@zhxchen17 @TharinduRusira
[export] Remove replace_sym_size_ops_pass (pytorch#128443)
e9170b1 
Summary: Not needed anymore.

Test Plan: CI

Differential Revision: D58429458

Pull Request resolved: pytorch#128443
Approved by: https://github.com/angelayi
ignaciobartol pushed a commit to ignaciobartol/pytorch that referenced this pull request Jun 14, 2024
@zhxchen17 @ignaciobartol
[export] Remove replace_sym_size_ops_pass (pytorch#128443)
446e4a4 
Summary: Not needed anymore.

Test Plan: CI

Differential Revision: D58429458

Pull Request resolved: pytorch#128443
Approved by: https://github.com/angelayi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@angelayi angelayi angelayi approved these changes

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri avikchaudhuri is a code owner

@gmagogsfm gmagogsfm Awaiting requested review from gmagogsfm

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhxchen17 @facebook-github-bot @pytorchmergebot @angelayi