Skip to content

Fix get output code when caching is enabled #128445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix get output code when caching is enabled #128445

wants to merge 1 commit into from

Conversation

oulgen
Copy link
Contributor

@oulgen oulgen commented Jun 11, 2024 •
edited by pytorch-bot bot
Loading

Summary: Improve output code retrieval mechanism so that it works in the presence of cache hits.

Test Plan: ci

Differential Revision: D58429602

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 11, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128445

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit ea0d619 with merge base 5001f41 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58429602

@oulgen oulgen requested review from eellison, jansel and masnesral June 11, 2024 20:28
@oulgen oulgen added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Jun 11, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58429602

@oulgen oulgen force-pushed the export-D58429602 branch from 6fc540d to 0e79d56 Compare June 11, 2024 20:36
masnesral
masnesral reviewed Jun 11, 2024
View reviewed changes
torch/_inductor/utils.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove this comment

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58429602

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58429602

oulgen added a commit that referenced this pull request Jun 11, 2024
@oulgen @facebook-github-bot
Fix get output code when caching is enabled (#128445)
790a7bf 
Summary:
Pull Request resolved: #128445

Improve output code retrieval mechanism so that it works in the presence of cache hits.

Test Plan: ci

Differential Revision: D58429602
@oulgen oulgen force-pushed the export-D58429602 branch from 9e8e861 to 790a7bf Compare June 11, 2024 23:13
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58429602

@oulgen oulgen force-pushed the export-D58429602 branch from f0eb190 to 18a6d1f Compare June 12, 2024 17:14
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58429602

masnesral
masnesral reviewed Jun 12, 2024
View reviewed changes
test/inductor/test_torchinductor.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug here? There's no inps list any more

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is what happens when i have to run tests on OSS but export from fbcode :/

masnesral
masnesral reviewed Jun 12, 2024
View reviewed changes
test/inductor/test_torchinductor.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should both pass inps2?

@oulgen oulgen force-pushed the export-D58429602 branch from 18a6d1f to 229cd41 Compare June 12, 2024 17:20
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58429602

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58429602

@oulgen @facebook-github-bot
Fix get output code when caching is enabled (#128445)
ea0d619 
Summary:
Pull Request resolved: #128445

Improve output code retrieval mechanism so that it works in the presence of cache hits.

Test Plan: ci

Reviewed By: masnesral

Differential Revision: D58429602
@oulgen oulgen force-pushed the export-D58429602 branch from 41a2515 to ea0d619 Compare June 12, 2024 17:28
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58429602

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

TharinduRusira pushed a commit to TharinduRusira/pytorch that referenced this pull request Jun 14, 2024
@oulgen @TharinduRusira
Fix get output code when caching is enabled (pytorch#128445)
80d548e 
Summary: Improve output code retrieval mechanism so that it works in the presence of cache hits.

Test Plan: ci

Differential Revision: D58429602

Pull Request resolved: pytorch#128445
Approved by: https://github.com/jansel, https://github.com/eellison, https://github.com/masnesral
ignaciobartol pushed a commit to ignaciobartol/pytorch that referenced this pull request Jun 14, 2024
@oulgen @ignaciobartol
Fix get output code when caching is enabled (pytorch#128445)
4617d3d 
Summary: Improve output code retrieval mechanism so that it works in the presence of cache hits.

Test Plan: ci

Differential Revision: D58429602

Pull Request resolved: pytorch#128445
Approved by: https://github.com/jansel, https://github.com/eellison, https://github.com/masnesral
@github-actions github-actions bot deleted the export-D58429602 branch July 14, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masnesral masnesral masnesral approved these changes

@jansel jansel jansel approved these changes

@eellison eellison eellison approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@oulgen @facebook-github-bot @pytorchmergebot @jansel @eellison @masnesral