shape_as_tensor should return a CPU tensor #12846
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
jamesr66a has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jamesr66a
force-pushed
the
fix_shape_as_tensor
branch
2 times, most recently
from
22d6263 to
c93208c
Compare
There was a problem hiding this comment.
jamesr66a has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
approved these changes
Oct 19, 2018
jamesr66a
force-pushed
the
fix_shape_as_tensor
branch
from
c93208c to
8dbde6e
Compare
There was a problem hiding this comment.
jamesr66a has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jamesr66a
force-pushed
the
fix_shape_as_tensor
branch
from
8dbde6e to
8b149ef
Compare
There was a problem hiding this comment.
jamesr66a has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 19, 2018
Summary: Pull Request resolved: pytorch/pytorch#12846 Differential Revision: D10456885 Pulled By: jamesr66a fbshipit-source-id: fa66d0736cfb0ed09e566ae7c2eaeac37f8bb0e4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.