fix: Print statements causing parse error #128969
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128969
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2b1940e with merge base 4817180 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zxiiro
force-pushed
the
zxiiro/fix-print
branch
2 times, most recently
from
8b327a9 to
430acfd
Compare
The print statements for the get_workflow_type script is problematic because the shell script calling this script is expecting the output to only be JSON. This PR resolves this by removing all print statements to covert them to a message field in the JSON return output so that the output can continue to expect to be JSON while giving us the debug data we are looking for. Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
tylertitsworth
approved these changes
Jun 18, 2024
ZainRizvi
approved these changes
Jun 18, 2024
| if user_list[0] == "!": | ||
| print("LF Workflows are disabled for everyone. Using meta runners.") | ||
| return WORKFLOW_LABEL_META | ||
| MESSAGE = "LF Workflows are disabled for everyone. Using meta runners." |
There was a problem hiding this comment.
nit: Does this really need to use a global variable?
There was a problem hiding this comment.
Not really but I wanted to put it above so that it's documented together with the other fields that are returned to caller and immediately viewable when reading this file.
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The print statements for the get_workflow_type script is problematic because the shell script calling this script is expecting the output to only be JSON. This PR resolves this by removing all print statements to covert them to a message field in the JSON return output so that the output can continue to expect to be JSON while giving us the debug data we are looking for.