Skip to content

Conversation

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129181

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (8 Unrelated Failures)

As of commit b999cb8 with merge base 9d06e37 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, one question

in_compiled_autograd_region = True
for i in runtime_inputs_to_move:
inputs[i] = inputs[i].cuda()
inputs[i] = inputs[i].pin_memory().cuda(non_blocking=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put a numel() limit on this ? The general guidance for pin memory is to avoid overallocating.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess it doesn't matter rn since every input in runtime_inputs_to_move would have numel=1

@xmfan xmfan added the topic: not user facing topic category label Jun 21, 2024
pytorchmergebot pushed a commit that referenced this pull request Jun 21, 2024
covered by test_compiled_autograd.py and test_standalone_compile.py

Pull Request resolved: #129116
Approved by: https://github.com/jansel
ghstack dependencies: #127960, #128905, #128982, #128987, #129181
@github-actions github-actions bot deleted the gh/xmfan/69/head branch July 23, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants