Skip to content

[CUDAGraph Trees] Enable input mutation support in OSS #129184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[CUDAGraph Trees] Enable input mutation support in OSS #129184

wants to merge 1 commit into from

Conversation

BoyuanFeng
Copy link
Contributor

@BoyuanFeng BoyuanFeng commented Jun 20, 2024 •
edited by pytorch-bot bot
Loading

Summary: Enable input mutation support for cudagraph trees in OSS.

Test Plan: CI

Differential Revision: D58847850

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 20, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129184

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 9a6b31b with merge base 8a2fed7 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58847850

@BoyuanFeng BoyuanFeng requested a review from eellison June 20, 2024 23:47
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58847850

BoyuanFeng added a commit to BoyuanFeng/pytorch that referenced this pull request Jun 20, 2024
@BoyuanFeng @facebook-github-bot
[CUDAGraph Trees] Enable input mutation support in OSS (pytorch#129184)
634f7ec 
Summary:
Pull Request resolved: pytorch#129184

Enable input mutation support for cudagraph trees in OSS.

Test Plan: CI

Differential Revision: D58847850
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58847850

@BoyuanFeng @facebook-github-bot
[CUDAGraph Trees] Enable input mutation support in OSS (pytorch#129184)
9a6b31b 
Summary:
Pull Request resolved: pytorch#129184

Enable input mutation support for cudagraph trees in OSS.

Test Plan: CI

Differential Revision: D58847850
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58847850

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 26, 2024
@BoyuanFeng
Copy link
Contributor Author

@pytorchbot merge

@BoyuanFeng BoyuanFeng self-assigned this Jun 26, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@BoyuanFeng BoyuanFeng added the topic: not user facing topic category label Jun 27, 2024
@BoyuanFeng
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@BoyuanFeng BoyuanFeng deleted the export-D58847850 branch June 27, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eellison eellison eellison approved these changes

Assignees

@BoyuanFeng BoyuanFeng

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BoyuanFeng @facebook-github-bot @pytorchmergebot @eellison