Skip to content

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Jun 25, 2024

MacOS uses case-insensitive filesystem by default, but it's better to specify include path using proper capitalization

Should fix

MultiTensorApply.h:4:10: warning: non-portable path to file '<ATen/native/mps/operations/FusedOptimizerOps.h>'; specified path differs in case from file name on disk [-Wnonportable-include-path]
#include <Aten/native/mps/operations/FusedOptimizerOps.h>

MacOS uses case-insensitive filesystem by default, but it's better to specify include path using proper capitalization

Should fix 
```
MultiTensorApply.h:4:10: warning: non-portable path to file '<ATen/native/mps/operations/FusedOptimizerOps.h>'; specified path differs in case from file name on disk [-Wnonportable-include-path]
#include <Aten/native/mps/operations/FusedOptimizerOps.h>
```
@malfet malfet requested a review from kulinseth as a code owner June 25, 2024 13:55
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 25, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129474

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 21 Unrelated Failures

As of commit 6935dfd with merge base 71ebe51 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Jun 25, 2024
@malfet malfet requested review from a team and qqaatw and removed request for kulinseth June 25, 2024 13:55
@malfet malfet added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Jun 25, 2024
@malfet
Copy link
Contributor Author

malfet commented Jun 25, 2024

@pytorchbot merge -f "Lint + Mac builds are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet malfet deleted the malfet-patch-7 branch July 10, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: mps Release notes category topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants