Skip to content

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Jun 27, 2024

As it often fails during conda install step with Unexpected HTTP response: 429

As it often fails during conda install step with `Unexpected HTTP response: 429`
@malfet malfet requested a review from a team as a code owner June 27, 2024 23:52
Copy link

pytorch-bot bot commented Jun 27, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129722

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 21a5f3b with merge base 9554a9a (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jun 27, 2024
Copy link
Contributor

@clee2000 clee2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theres one in periodic and slow as well

@kit1980
Copy link
Contributor

kit1980 commented Jun 27, 2024

Let's leave periodic and slow as is?

@malfet
Copy link
Contributor Author

malfet commented Jun 27, 2024

Let's leave periodic and slow as is?

Aren't broken slow job will block promotions? But I can leave it in periodic if somebody can confirm it's not blocking viable/strict

@kit1980
Copy link
Contributor

kit1980 commented Jun 28, 2024

Aren't broken slow job will block promotions?

Can it block? It doesn't run on every commit.
And if we stop trunk and pull, likely 429 will disappear

@malfet malfet added ciflow/trunk Trigger trunk jobs on your pull request ciflow/slow labels Jun 28, 2024
@malfet
Copy link
Contributor Author

malfet commented Jun 28, 2024

Aren't broken slow job will block promotions?

Can it block? It doesn't run on every commit. And if we stop trunk and pull, likely 429 will disappear

429 is an temporary thing, it will likely disappear on its own in 30 min or so, but we should not have a job that installs conda every single run

Copy link

pytorch-bot bot commented Jun 28, 2024

You need to provide a reason for using force merge, in the format @pytorchbot merge -f 'Explanation'.
The explanation needs to be clear on why this is needed. Here are some good examples:

  • Bypass checks due to unrelated upstream failures from ...
  • This is a minor fix to ..., which shouldn't break anything
  • This is pre-tested in a previous CI run
  • Bypass flaky ... check

@malfet
Copy link
Contributor Author

malfet commented Jun 28, 2024

@pytorchbot merge -f "I see pull trunk and slow jobs being scheduled"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Jul 3, 2024
…129720)

Undo #129722

Use the setup-miniconda step in written in test-infra to install miniconda in the llm retrieval workflow.  It comes with a cache so we don't have to worry about hitting cache limits.  The llm retrieval job was failing due to too many requests #129718 (comment)

https://github.com/pytorch/test-infra/blob/2aba8f107aca99710cca5cd97b6c16500eb808e2/.github/actions/setup-miniconda/action.yml#L1
Pull Request resolved: #129720
Approved by: https://github.com/PaliC, https://github.com/malfet, https://github.com/huydhn
@github-actions github-actions bot deleted the malfet/disable-llm-td branch July 29, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/slow ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants