-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Disable llm-td step #129722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable llm-td step #129722
Conversation
As it often fails during conda install step with `Unexpected HTTP response: 429`
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129722
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 21a5f3b with merge base 9554a9a ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
theres one in periodic and slow as well
Let's leave periodic and slow as is? |
Aren't broken slow job will block promotions? But I can leave it in periodic if somebody can confirm it's not blocking viable/strict |
Can it block? It doesn't run on every commit. |
429 is an temporary thing, it will likely disappear on its own in 30 min or so, but we should not have a job that installs conda every single run |
You need to provide a reason for using force merge, in the format @pytorchbot merge -f 'Explanation'.
|
@pytorchbot merge -f "I see pull trunk and slow jobs being scheduled" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…129720) Undo #129722 Use the setup-miniconda step in written in test-infra to install miniconda in the llm retrieval workflow. It comes with a cache so we don't have to worry about hitting cache limits. The llm retrieval job was failing due to too many requests #129718 (comment) https://github.com/pytorch/test-infra/blob/2aba8f107aca99710cca5cd97b6c16500eb808e2/.github/actions/setup-miniconda/action.yml#L1 Pull Request resolved: #129720 Approved by: https://github.com/PaliC, https://github.com/malfet, https://github.com/huydhn
As it often fails during conda install step with
Unexpected HTTP response: 429