[2/N] Replace exceptions with static_assert(false) in some templates #130116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyyever
requested review from
IvanYashchuk,
eqy,
lezcano and
nikitaved
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130116
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit a5ade25 with merge base d496145 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
module: cpu
cyyever
force-pushed
the
static_assert3
branch
4 times, most recently
from
8ffa906 to
06e3214
Compare
eqy
approved these changes
Jul 5, 2024
A trick to let static_assert depend on specific template instantiations. |
|
@pytorchmergebot merge |
Merge failedReason: Approvers from one of the following sets are needed:
|
ezyang
approved these changes
Jul 6, 2024
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 1 checks: trunk / win-vs2019-cpu-py3 / test (default, 2, 3, windows.4xlarge.nonephemeral) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #127371
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10