Fix TensorList ambiguity #13024
Closed
Fix TensorList ambiguity #13024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D10518929 Differential Version: 61460627
smessmer
force-pushed
the
export-D10518929
branch
from
b21da37 to
6e11fb0
Compare
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 25, 2018
Summary: Pull Request resolved: pytorch/pytorch#13024 There's a TensorList type in ivalue.h and one in ScalarType.h, and they are different. This diff moves IValue types into an ivalue namespace so we can merge the namespaces without conflicts. Reviewed By: ezyang Differential Revision: D10518929 fbshipit-source-id: cb760b6804a399880d2bff3acf9a3422d99fc0b8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #13024 Fix TensorList ambiguity 💛
:white_circle: #12950 Include c10 namespace into caffe2 and at namespaces. 💚
There's a TensorList type in ivalue.h and one in ScalarType.h, and they are different.
This diff moves IValue types into an ivalue namespace so we can merge the namespaces without conflicts.
Differential Revision: D10518929