[CCA][Memory Snapshot] Stop duplicating annotations to all device_traces #130315
Conversation
Summary: This diff fixes a bug, where all record_annotations will save a TraceEntry to each of the device_traces. Instead, we should only save annotations to the current device_trace that is being called by the thread calling the native allocator's recordAnnotation. Test Plan: CI and ran workloads on MVAI WPR FBR. Reviewed By: zdevito Differential Revision: D59477339 Pulled By: aaronenyeshi
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130315
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b0240c3 with merge base 6c4efd4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D59477339 |
aaronenyeshi
requested review from
chaekit,
davidberard98,
tianfengfrank and
zdevito
aaronenyeshi
added
ciflow/trunk
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…ces (pytorch#130315) Summary: This diff fixes a bug, where all record_annotations will save a TraceEntry to each of the device_traces. Instead, we should only save annotations to the current device_trace that is being called by the thread calling the native allocator's recordAnnotation. Test Plan: CI and ran workloads on MVAI WPR FBR. Reviewed By: zdevito Differential Revision: D59477339 Pulled By: aaronenyeshi Pull Request resolved: pytorch#130315 Approved by: https://github.com/zdevito
…ces (pytorch#130315) Summary: This diff fixes a bug, where all record_annotations will save a TraceEntry to each of the device_traces. Instead, we should only save annotations to the current device_trace that is being called by the thread calling the native allocator's recordAnnotation. Test Plan: CI and ran workloads on MVAI WPR FBR. Reviewed By: zdevito Differential Revision: D59477339 Pulled By: aaronenyeshi Pull Request resolved: pytorch#130315 Approved by: https://github.com/zdevito
4 participants
Summary: This diff fixes a bug, where all record_annotations will save a TraceEntry to each of the device_traces. Instead, we should only save annotations to the current device_trace that is being called by the thread calling the native allocator's recordAnnotation.
Test Plan: CI and ran workloads on MVAI WPR FBR.
Reviewed By: zdevito
Differential Revision: D59477339
Pulled By: aaronenyeshi