Skip to content

[3.13, dynamo] fix CALL_FUNCTION_EX in symbolic_convert #130460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[3.13, dynamo] fix CALL_FUNCTION_EX in symbolic_convert #130460

wants to merge 6 commits into from

Conversation

@williamwen42
Copy link
Member

@williamwen42 williamwen42 commented Jul 10, 2024 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 10, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130460

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b054f67 with merge base 25cb442 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jul 10, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jul 11, 2024
Closed
Closed
Closed
Closed
Closed
Closed
@williamwen42 williamwen42 added the topic: not user facing topic category label Jul 11, 2024
jansel
jansel approved these changes Jul 11, 2024
View reviewed changes
torch/_dynamo/symbolic_convert.py
self._load_fast(inst.argval[0])
self._load_fast(inst.argval[1])

def STORE_FAST_STORE_FAST(self, inst):
Copy link
Contributor

@jansel jansel Jul 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meant to go in prior PR?

@williamwen42
Update on "[3.13, dynamo] fix CALL_FUNCTION_EX in symbolic_convert"
483ca3f 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@williamwen42
Update on "[3.13, dynamo] fix CALL_FUNCTION_EX in symbolic_convert"
aa99fea 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@williamwen42 williamwen42 mentioned this pull request Jul 15, 2024
Closed
@williamwen42
Update on "[3.13, dynamo] fix CALL_FUNCTION_EX in symbolic_convert"
191d02e 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@williamwen42
Update on "[3.13, dynamo] fix CALL_FUNCTION_EX in symbolic_convert"
b054f67 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Jul 17, 2024
@williamwen42 @pytorchmergebot
[3.13, dynamo] fix instruction line numbers (#130461)
e2365c0 
Pull Request resolved: #130461
Approved by: https://github.com/jansel
ghstack dependencies: #130459, #130460
pytorchmergebot pushed a commit that referenced this pull request Jul 17, 2024
@williamwen42 @pytorchmergebot
[3.13, dynamo] support CALL_KW (#130564)
539acf7 
Pull Request resolved: #130564
Approved by: https://github.com/jansel
ghstack dependencies: #130459, #130460, #130461
pytorchmergebot pushed a commit that referenced this pull request Jul 17, 2024
@williamwen42 @pytorchmergebot
[3.13, dynamo] support TO_BOOL (#130565)
2300bb2 
Pull Request resolved: #130565
Approved by: https://github.com/jansel
ghstack dependencies: #130459, #130460, #130461, #130564
mlazos pushed a commit that referenced this pull request Jul 18, 2024
@williamwen42 @mlazos
[3.13, dynamo] fix CALL_FUNCTION_EX in symbolic_convert (#130460)
749d1a3 
Pull Request resolved: #130460
Approved by: https://github.com/jansel
ghstack dependencies: #130459
mlazos pushed a commit that referenced this pull request Jul 18, 2024
@williamwen42 @mlazos
[3.13, dynamo] fix instruction line numbers (#130461)
39b7812 
Pull Request resolved: #130461
Approved by: https://github.com/jansel
ghstack dependencies: #130459, #130460
mlazos pushed a commit that referenced this pull request Jul 18, 2024
@williamwen42 @mlazos
[3.13, dynamo] support CALL_KW (#130564)
f34387d 
Pull Request resolved: #130564
Approved by: https://github.com/jansel
ghstack dependencies: #130459, #130460, #130461
mlazos pushed a commit that referenced this pull request Jul 18, 2024
@williamwen42 @mlazos
[3.13, dynamo] support TO_BOOL (#130565)
428e5c0 
Pull Request resolved: #130565
Approved by: https://github.com/jansel
ghstack dependencies: #130459, #130460, #130461, #130564
DiweiSun pushed a commit to DiweiSun/pytorch that referenced this pull request Jul 22, 2024
@williamwen42 @DiweiSun
[3.13, dynamo] fix CALL_FUNCTION_EX in symbolic_convert (pytorch#130460)
c87f800 
Pull Request resolved: pytorch#130460
Approved by: https://github.com/jansel
ghstack dependencies: pytorch#130459
DiweiSun pushed a commit to DiweiSun/pytorch that referenced this pull request Jul 22, 2024
@williamwen42 @DiweiSun
[3.13, dynamo] fix instruction line numbers (pytorch#130461)
04d978c 
Pull Request resolved: pytorch#130461
Approved by: https://github.com/jansel
ghstack dependencies: pytorch#130459, pytorch#130460
DiweiSun pushed a commit to DiweiSun/pytorch that referenced this pull request Jul 22, 2024
@williamwen42 @DiweiSun
[3.13, dynamo] support CALL_KW (pytorch#130564)
325a127 
Pull Request resolved: pytorch#130564
Approved by: https://github.com/jansel
ghstack dependencies: pytorch#130459, pytorch#130460, pytorch#130461
DiweiSun pushed a commit to DiweiSun/pytorch that referenced this pull request Jul 22, 2024
@williamwen42 @DiweiSun
[3.13, dynamo] support TO_BOOL (pytorch#130565)
bb2d463 
Pull Request resolved: pytorch#130565
Approved by: https://github.com/jansel
ghstack dependencies: pytorch#130459, pytorch#130460, pytorch#130461, pytorch#130564
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
@williamwen42 @xuhancn
[3.13, dynamo] fix CALL_FUNCTION_EX in symbolic_convert (pytorch#130460)
f757510 
Pull Request resolved: pytorch#130460
Approved by: https://github.com/jansel
ghstack dependencies: pytorch#130459
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
@williamwen42 @xuhancn
[3.13, dynamo] fix instruction line numbers (pytorch#130461)
0e640e6 
Pull Request resolved: pytorch#130461
Approved by: https://github.com/jansel
ghstack dependencies: pytorch#130459, pytorch#130460
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
@williamwen42 @xuhancn
[3.13, dynamo] support CALL_KW (pytorch#130564)
a44f502 
Pull Request resolved: pytorch#130564
Approved by: https://github.com/jansel
ghstack dependencies: pytorch#130459, pytorch#130460, pytorch#130461
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
@williamwen42 @xuhancn
[3.13, dynamo] support TO_BOOL (pytorch#130565)
6bd7877 
Pull Request resolved: pytorch#130565
Approved by: https://github.com/jansel
ghstack dependencies: pytorch#130459, pytorch#130460, pytorch#130461, pytorch#130564
@github-actions github-actions bot deleted the gh/williamwen42/108/head branch August 17, 2024 02:01
@williamwen42 williamwen42 added the module: python version Issues related to specific Python versions label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

@anijain2305 anijain2305 Awaiting requested review from anijain2305

Assignees

No one assigned

Labels

ciflow/inductor Merged module: dynamo module: python version Issues related to specific Python versions topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@williamwen42 @jansel @pytorchmergebot