Skip to content

Add JK to enable fx graph cache for amd #130463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add JK to enable fx graph cache for amd #130463

wants to merge 1 commit into from

Conversation

@oulgen
Copy link
Contributor

@oulgen oulgen commented Jul 10, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 10, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130463

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit e7ac602 with merge base 0beeac3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59593961

@oulgen oulgen added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Jul 10, 2024
@oulgen oulgen requested review from mxz297 and nmacchioni July 10, 2024 17:46
@oulgen @facebook-github-bot
Add JK to enable fx graph cache for amd (#130463)
e7ac602 
Summary: Pull Request resolved: #130463

Test Plan: ad hoc testing

Differential Revision: D59593961
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59593961

@oulgen oulgen force-pushed the export-D59593961 branch from 8b22995 to e7ac602 Compare July 10, 2024 17:51
nmacchioni
nmacchioni approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@nmacchioni nmacchioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mxz297
mxz297 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@mxz297 mxz297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that this (along with some changes in the user code) reduces torch.compile time in hot cache case on AMD from about 700s to 52s

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@henrylhtsang henrylhtsang mentioned this pull request Jul 17, 2024
Closed
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
@oulgen @xuhancn
Add JK to enable fx graph cache for amd (pytorch#130463)
52c47fa 
Test Plan: ad hoc testing

Differential Revision: D59593961

Pull Request resolved: pytorch#130463
Approved by: https://github.com/nmacchioni, https://github.com/mxz297
@github-actions github-actions bot deleted the export-D59593961 branch August 12, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxz297 mxz297 mxz297 approved these changes

@nmacchioni nmacchioni nmacchioni approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@oulgen @facebook-github-bot @pytorchmergebot @mxz297 @nmacchioni