Convert some docstrings from char* to char[] #13062
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Focusing on operators in common use on mobile. Also use GRADIENT_OPERATOR_SCHEMA. Differential Revision: D10245216 fbshipit-source-id: 5100c7b541941de48e49e9458b26f0f3a5499a95
Summary: Gold (the linker) isn't able to gc unreferenced string constants, but converting these to arrays puts them in their own data sections and reduces (Android) binary size as a result. I'm told even in server builds, this reduces binary size by a few dozen bytes and speeds up startup by a few hundred ns. :-P Reviewed By: Yangqing Differential Revision: D10510808 fbshipit-source-id: 734412fd6b3d0545c8d85d2232400d2494031d55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Gold (the linker) isn't able to gc unreferenced string constants, but
converting these to arrays puts them in their own data sections and reduces
(Android) binary size as a result.
I'm told even in server builds, this reduces binary size by a few dozen bytes
and speeds up startup by a few hundred ns. :-P
Reviewed By: Yangqing
Differential Revision: D10510808