Skip to content

Conversation

etaf
Copy link
Collaborator

@etaf etaf commented Jul 16, 2024

test_triton_kernels.py::test_add_kernel.
Fix #130814

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jul 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130817

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit 99f9396 with merge base e11c410 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@etaf etaf changed the title [Inductor UT] Generalize device-bias code in [Inductor UT] Generalize device-bias code in test_triton_kernels.py::test_add_kernel. Jul 16, 2024
@etaf etaf added the ciflow/xpu Run XPU CI tasks label Jul 16, 2024
@etaf etaf requested review from zou3519 and removed request for zou3519 July 16, 2024 07:19
@etaf etaf requested a review from EikanWang July 16, 2024 08:42
@etaf etaf self-assigned this Jul 16, 2024
etaf added 2 commits July 16, 2024 07:25
…ernels.py::test_add_kernel."


[Inductor UT] Generalize device-bias code in test_triton_kernels.py::test_add_kernel.
Fix #130814

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
…ernels.py and test_torchinductor.py"


[Inductor UT] Generalize newly introduced device-bias code in test_triton_kernels.py::test_add_kernel and test_torchinductor.py::test_ctr_not_moved_to_cuda_when_used_in_index_put
Fix #130814 , #130838

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@etaf etaf changed the title [Inductor UT] Generalize device-bias code in test_triton_kernels.py::test_add_kernel. [Inductor UT] Generalize device-bias code in test_triton_kernels.py::test_add_kernel test_torchinductor.py:TritonCodeGenTests.test_ctr_not_moved_to_cuda_when_used_in_index_put Jul 16, 2024
@etaf etaf changed the title [Inductor UT] Generalize device-bias code in test_triton_kernels.py::test_add_kernel test_torchinductor.py:TritonCodeGenTests.test_ctr_not_moved_to_cuda_when_used_in_index_put [Inductor UT] Generalize device-bias code in test_triton_kernels.py and test_torchinductor.py Jul 16, 2024
@etaf etaf added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 17, 2024
@etaf
Copy link
Collaborator Author

etaf commented Jul 17, 2024

The three failed job:
xpu / linux-jammy-xpu-py3.8 / test (default, 1, 4, linux.idc.xpu) (gh)
inductor/test_torchinductor.py::GPUTests::test_uint_xpu
xpu / linux-jammy-xpu-py3.8 / test (default, 3, 4, linux.idc.xpu) (gh)
inductor/test_torchinductor_dynamic_shapes.py::DynamicShapesGPUTests::test_uint_dynamic_shapes_xpu
xpu / linux-jammy-xpu-py3.8 / test (default, 4, 4, linux.idc.xpu) (gh)
inductor/test_torchinductor_codegen_dynamic_shapes.py::DynamicShapesCodegenGPUTests::test_uint_dynamic_shapes_xpu

has been fixed in the next stacked PR. Please ignore them.

pytorchmergebot pushed a commit that referenced this pull request Jul 17, 2024
@etaf etaf deleted the gh/etaf/28/head branch July 17, 2024 15:24
mlazos pushed a commit that referenced this pull request Jul 18, 2024
…nd test_torchinductor.py (#130817)

[Inductor UT] Generalize newly introduced device-bias code in test_triton_kernels.py::test_add_kernel and test_torchinductor.py::test_ctr_not_moved_to_cuda_when_used_in_index_put
Fix #130814 , #130838

Pull Request resolved: #130817
Approved by: https://github.com/zou3519
mlazos pushed a commit that referenced this pull request Jul 18, 2024
DiweiSun pushed a commit to DiweiSun/pytorch that referenced this pull request Jul 22, 2024
…nd test_torchinductor.py (pytorch#130817)

[Inductor UT] Generalize newly introduced device-bias code in test_triton_kernels.py::test_add_kernel and test_torchinductor.py::test_ctr_not_moved_to_cuda_when_used_in_index_put
Fix pytorch#130814 , pytorch#130838

Pull Request resolved: pytorch#130817
Approved by: https://github.com/zou3519
DiweiSun pushed a commit to DiweiSun/pytorch that referenced this pull request Jul 22, 2024
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
…nd test_torchinductor.py (pytorch#130817)

[Inductor UT] Generalize newly introduced device-bias code in test_triton_kernels.py::test_add_kernel and test_torchinductor.py::test_ctr_not_moved_to_cuda_when_used_in_index_put
Fix pytorch#130814 , pytorch#130838

Pull Request resolved: pytorch#130817
Approved by: https://github.com/zou3519
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks Merged module: inductor open source topic: not user facing topic category

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants