Renamed mask_fn to mask_mod #130818

Chillee · 2024-07-16T07:11:38Z

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang

[ghstack-poisoned]

pytorch-bot · 2024-07-16T07:11:41Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130818

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (11 Unrelated Failures)

As of commit e3899db with merge base 1d8baa4 ():

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 2, 5, linux.4xlarge.nvidia.gpu) (gh) (trunk failure)
test_sympy_utils.py::TestValueRanges::test_binary_ref_fn_floordiv_dtype_float
pull / linux-focal-cuda12.1-py3.10-gcc9-experimental-split-build / test (default, 2, 5, linux.4xlarge.nvidia.gpu) (gh) (trunk failure)
test_sympy_utils.py::TestValueRanges::test_binary_ref_fn_floordiv_dtype_float
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 2, 5, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
test_sympy_utils.py::TestValueRanges::test_binary_ref_fn_floordiv_dtype_float
pull / linux-focal-py3.11-clang10 / test (crossref, 1, 2, linux.2xlarge) (gh) (trunk failure)
test_sympy_utils.py::TestValueRanges::test_binary_ref_fn_floordiv_dtype_float
pull / linux-focal-py3.11-clang10 / test (default, 2, 4, linux.2xlarge) (gh) (trunk failure)
test_sympy_utils.py::TestValueRanges::test_binary_ref_fn_floordiv_dtype_float
pull / linux-focal-py3.11-clang10 / test (dynamo, 3, 3, linux.2xlarge) (gh) (trunk failure)
test_sympy_utils.py::TestValueRanges::test_binary_ref_fn_floordiv_dtype_float
pull / linux-focal-py3.8-clang10 / test (crossref, 1, 2, linux.2xlarge) (gh) (trunk failure)
test_sympy_utils.py::TestValueRanges::test_binary_ref_fn_floordiv_dtype_float
pull / linux-focal-py3.8-clang10 / test (default, 2, 4, linux.2xlarge) (gh) (trunk failure)
test_sympy_utils.py::TestValueRanges::test_binary_ref_fn_floordiv_dtype_float
pull / linux-focal-py3.8-clang10 / test (dynamo, 3, 3, linux.2xlarge) (gh) (trunk failure)
test_sympy_utils.py::TestValueRanges::test_binary_ref_fn_floordiv_dtype_float
pull / linux-jammy-py3.10-clang15-asan / test (default, 2, 6, linux.4xlarge) (gh) (trunk failure)
test_sympy_utils.py::TestValueRanges::test_binary_ref_fn_floordiv_dtype_float
pull / linux-jammy-py3.8-gcc11 / test (default, 2, 4, linux.2xlarge) (gh) (trunk failure)
test_sympy_utils.py::TestValueRanges::test_binary_ref_fn_floordiv_dtype_float

This comment was automatically generated by Dr. CI and updates every 15 minutes.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

ghstack-source-id: 3e52ef9 Pull Request resolved: #130818

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

drisspg

One comment

torch/nn/attention/flex_attention.py

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

Pull Request resolved: #130819 Approved by: https://github.com/drisspg ghstack dependencies: #130809, #130818

This reverts commit 03c6604. Reverted #130819 on behalf of https://github.com/atalman due to Internal problem with previous PR in stack #130818 ([comment](#130819 (comment)))

atalman · 2024-07-17T13:45:22Z

@pytorchmergebot revert -c ghfirst -m "Failing internally"

pytorchmergebot · 2024-07-17T13:46:59Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2024-07-17T13:47:11Z

@Chillee your PR has been successfully reverted.

This reverts commit 1a97bcf. Reverted #130818 on behalf of https://github.com/atalman due to Failing internally ([comment](#130818 (comment)))

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

Pull Request resolved: pytorch#130869 Approved by: https://github.com/drisspg, https://github.com/joydddd ghstack dependencies: pytorch#130809, pytorch#130818

Pull Request resolved: #130818 Approved by: https://github.com/drisspg ghstack dependencies: #130809

Pull Request resolved: #130819 Approved by: https://github.com/drisspg ghstack dependencies: #130809, #130818

This reverts commit 03c6604. Reverted #130819 on behalf of https://github.com/atalman due to Internal problem with previous PR in stack #130818 ([comment](#130819 (comment)))

This reverts commit 1a97bcf. Reverted #130818 on behalf of https://github.com/atalman due to Failing internally ([comment](#130818 (comment)))

Pull Request resolved: #130818 Approved by: https://github.com/drisspg ghstack dependencies: #130809

Pull Request resolved: #130869 Approved by: https://github.com/drisspg, https://github.com/joydddd ghstack dependencies: #130809, #130818

This reverts commit 03c6604. Reverted pytorch#130819 on behalf of https://github.com/atalman due to Internal problem with previous PR in stack pytorch#130818 ([comment](pytorch#130819 (comment)))

This reverts commit 1a97bcf. Reverted pytorch#130818 on behalf of https://github.com/atalman due to Failing internally ([comment](pytorch#130818 (comment)))

Pull Request resolved: pytorch#130818 Approved by: https://github.com/drisspg ghstack dependencies: pytorch#130809

Pull Request resolved: pytorch#130869 Approved by: https://github.com/drisspg, https://github.com/joydddd ghstack dependencies: pytorch#130809, pytorch#130818

ghstack-source-id: 116ecc6 Pull Request resolved: pytorch/pytorch#130818

Pull Request resolved: pytorch#130818 Approved by: https://github.com/drisspg ghstack dependencies: pytorch#130809

Pull Request resolved: pytorch#130819 Approved by: https://github.com/drisspg ghstack dependencies: pytorch#130809, pytorch#130818

This reverts commit 03c6604. Reverted pytorch#130819 on behalf of https://github.com/atalman due to Internal problem with previous PR in stack pytorch#130818 ([comment](pytorch#130819 (comment)))

This reverts commit 1a97bcf. Reverted pytorch#130818 on behalf of https://github.com/atalman due to Failing internally ([comment](pytorch#130818 (comment)))

Pull Request resolved: pytorch#130818 Approved by: https://github.com/drisspg ghstack dependencies: pytorch#130809

Pull Request resolved: pytorch#130869 Approved by: https://github.com/drisspg, https://github.com/joydddd ghstack dependencies: pytorch#130809, pytorch#130818

Renamed mask_fn to mask_mod

071d565

[ghstack-poisoned]

Chillee requested review from albanD, jbschlosser and mikaylagawarecki as code owners July 16, 2024 07:11

This was referenced Jul 16, 2024

Activate dev #130808

Closed

Compute q_num_blocks from kv_num_blocks if q_num_blocks is not passed in #130809

Closed

pytorch-bot bot added ciflow/inductor module: inductor labels Jul 16, 2024

github-actions bot requested a review from ezyang July 16, 2024 07:11

Chillee added the suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) label Jul 16, 2024

Chillee requested review from drisspg and yanboliang July 16, 2024 07:14

Update on "Renamed mask_fn to mask_mod"

202ab59

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

Chillee added a commit that referenced this pull request Jul 16, 2024

Renamed mask_fn to mask_mod

57e373f

ghstack-source-id: 3e52ef9 Pull Request resolved: #130818

Chillee mentioned this pull request Jul 16, 2024

Removed q_num_blocks from constructor #130819

Closed

Chillee added 2 commits July 16, 2024 10:42

Update on "Renamed mask_fn to mask_mod"

dea2626

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

Update on "Renamed mask_fn to mask_mod"

f0bbfc3

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

drisspg approved these changes Jul 16, 2024

View reviewed changes

torch/nn/attention/flex_attention.py Outdated Show resolved Hide resolved

Update on "Renamed mask_fn to mask_mod"

9c9f1fd

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

albanD removed their request for review July 16, 2024 18:20

Chillee mentioned this pull request Jul 16, 2024

renamed inductor kernel args in flexattention properly #130869

Closed

drisspg mentioned this pull request Jul 16, 2024

Removing some cruff and updating signatures for consistency #130871

Closed

pytorchmergebot closed this in 1a97bcf Jul 17, 2024

pytorchmergebot pushed a commit that referenced this pull request Jul 17, 2024

Removed q_num_blocks from constructor (#130819)

03c6604

Pull Request resolved: #130819 Approved by: https://github.com/drisspg ghstack dependencies: #130809, #130818

pytorchmergebot added the Merged label Jul 17, 2024

Chillee mentioned this pull request Jul 17, 2024

Refactored flexattention kernel #130904

Closed

pytorchmergebot added a commit that referenced this pull request Jul 17, 2024

Revert "Renamed mask_fn to mask_mod (#130818)"

94a910b

This reverts commit 1a97bcf. Reverted #130818 on behalf of https://github.com/atalman due to Failing internally ([comment](#130818 (comment)))

pytorchmergebot added the Reverted label Jul 17, 2024

pytorchmergebot reopened this Jul 17, 2024

Update on "Renamed mask_fn to mask_mod"

e3899db

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]

pytorchmergebot closed this in 480a5bd Jul 17, 2024

mlazos pushed a commit that referenced this pull request Jul 18, 2024

Renamed mask_fn to mask_mod (#130818)

d5bfb07

Pull Request resolved: #130818 Approved by: https://github.com/drisspg ghstack dependencies: #130809

mlazos pushed a commit that referenced this pull request Jul 18, 2024

Removed q_num_blocks from constructor (#130819)

dfbedac

Pull Request resolved: #130819 Approved by: https://github.com/drisspg ghstack dependencies: #130809, #130818

mlazos pushed a commit that referenced this pull request Jul 18, 2024

Revert "Renamed mask_fn to mask_mod (#130818)"

ee26252

This reverts commit 1a97bcf. Reverted #130818 on behalf of https://github.com/atalman due to Failing internally ([comment](#130818 (comment)))

mlazos pushed a commit that referenced this pull request Jul 18, 2024

Renamed mask_fn to mask_mod (#130818)

f1a5ee8

Pull Request resolved: #130818 Approved by: https://github.com/drisspg ghstack dependencies: #130809

mlazos pushed a commit that referenced this pull request Jul 18, 2024

renamed inductor kernel args in flexattention properly (#130869)

4046d3b

Pull Request resolved: #130869 Approved by: https://github.com/drisspg, https://github.com/joydddd ghstack dependencies: #130809, #130818

DiweiSun pushed a commit to DiweiSun/pytorch that referenced this pull request Jul 22, 2024

Renamed mask_fn to mask_mod (pytorch#130818)

3fde42d

Pull Request resolved: pytorch#130818 Approved by: https://github.com/drisspg ghstack dependencies: pytorch#130809

francograndegmailcom pushed a commit to francograndegmailcom/pytorch-pytorch that referenced this pull request Jul 23, 2024

Renamed mask_fn to mask_mod

a307a36

ghstack-source-id: 116ecc6 Pull Request resolved: pytorch/pytorch#130818

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024

Renamed mask_fn to mask_mod (pytorch#130818)

5b6613e

Pull Request resolved: pytorch#130818 Approved by: https://github.com/drisspg ghstack dependencies: pytorch#130809

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024

Removed q_num_blocks from constructor (pytorch#130819)

8db9378

Pull Request resolved: pytorch#130819 Approved by: https://github.com/drisspg ghstack dependencies: pytorch#130809, pytorch#130818

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024

Renamed mask_fn to mask_mod (pytorch#130818)

8001e49

Pull Request resolved: pytorch#130818 Approved by: https://github.com/drisspg ghstack dependencies: pytorch#130809

github-actions bot deleted the gh/chillee/330/head branch August 17, 2024 02:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Renamed mask_fn to mask_mod #130818

Renamed mask_fn to mask_mod #130818

Uh oh!

Chillee commented Jul 16, 2024 •

edited

Loading

Uh oh!

pytorch-bot bot commented Jul 16, 2024 •

edited

Loading

Uh oh!

drisspg left a comment

Uh oh!

Uh oh!

atalman commented Jul 17, 2024

Uh oh!

pytorchmergebot commented Jul 17, 2024

Uh oh!

pytorchmergebot commented Jul 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Renamed mask_fn to mask_mod #130818

Renamed mask_fn to mask_mod #130818

Uh oh!

Conversation

Chillee commented Jul 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jul 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130818

✅ You can merge normally! (11 Unrelated Failures)

Uh oh!

drisspg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

atalman commented Jul 17, 2024

Uh oh!

pytorchmergebot commented Jul 17, 2024

Uh oh!

pytorchmergebot commented Jul 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Chillee commented Jul 16, 2024 •

edited

Loading

pytorch-bot bot commented Jul 16, 2024 •

edited

Loading