[inductor] Kill mark_node_as_mutating #130834

peterbell10 · 2024-07-16T12:29:47Z

Stack from ghstack (oldest at bottom):

Resubmit of #129346

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang

[ghstack-poisoned]

pytorch-bot · 2024-07-16T12:29:51Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130834

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 0e173be with merge base 1624798 ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m1-14) (gh) (detected as infra flaky with no log or failing log classifier)

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

periodic / linux-focal-cuda11.8-py3.10-gcc9-debug / test (default, 1, 5, linux.4xlarge.nvidia.gpu, unstable) (gh)
[ FAILED ] HalfCuda.HalfCuda
periodic / linux-focal-rocm6.1-py3.8 / test (distributed, 1, 2, linux.rocm.gpu) (gh) (#129209)
'Test'

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

peterbell10 · 2024-07-18T13:49:31Z

@pytorchbot merge

pytorchmergebot · 2024-07-18T13:51:33Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-07-18T13:57:17Z

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 0be7a3ff094172f52a21a04c9bcf57909d87300d returned non-zero exit code 1

Auto-merging torch/_inductor/ir.py
CONFLICT (content): Merge conflict in torch/_inductor/ir.py
error: could not apply 0be7a3ff09... [inductor] Kill mark_node_as_mutating
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

Details for Dev Infra team

Raised by workflow job

[ghstack-poisoned]

peterbell10 · 2024-07-18T14:14:30Z

@pytorchbot merge

pytorchmergebot · 2024-07-18T14:16:46Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-07-18T20:14:57Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

peterbell10 · 2024-07-18T21:15:18Z

@pytorchbot merge

pytorchmergebot · 2024-07-18T21:17:13Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-07-18T21:58:30Z

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator

Details for Dev Infra team

Raised by workflow job

peterbell10 · 2024-07-18T23:37:04Z

@pytorchbot merge -f "Imported for CI run only"

Resubmit of pytorch#129346 ghstack-source-id: 498a08b Pull Request resolved: pytorch#130834

atalman · 2024-07-22T22:01:05Z

@pytorchmergebot revert -c nosignal -m "broke periodic #130832"

pytorchmergebot · 2024-07-22T22:02:34Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

This reverts commit 33f036a. Reverted #130834 on behalf of https://github.com/atalman due to broke periodic #130832 ([comment](#130834 (comment)))

pytorchmergebot · 2024-07-22T22:02:46Z

@peterbell10 your PR has been successfully reverted.

[ghstack-poisoned]

Resubmit of pytorch#129346 ghstack-source-id: 0d8e6a9 Pull Request resolved: pytorch#130834

[ghstack-poisoned]

peterbell10 · 2024-07-24T11:03:51Z

@pytorchbot merge

pytorchmergebot · 2024-07-24T11:05:38Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Resubmit of pytorch#129346 Pull Request resolved: pytorch#130834 Approved by: https://github.com/lezcano ghstack dependencies: pytorch#130831, pytorch#130832, pytorch#130833

This reverts commit 33f036a. Reverted pytorch#130834 on behalf of https://github.com/atalman due to broke periodic pytorch#130832 ([comment](pytorch#130834 (comment)))

Resubmit of pytorch#129346 Pull Request resolved: pytorch#130834 Approved by: https://github.com/lezcano ghstack dependencies: pytorch#130832, pytorch#130833

Resubmit of #129346 ghstack-source-id: 2737a81 Pull Request resolved: pytorch/pytorch#130834

Update

cfbbed8

[ghstack-poisoned]

pytorch-bot bot added ciflow/inductor module: inductor labels Jul 16, 2024

peterbell10 added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Jul 16, 2024

pytorchbot added the open source label Jul 16, 2024

peterbell10 requested a review from lezcano July 16, 2024 12:31

lezcano approved these changes Jul 16, 2024

View reviewed changes

Update

7d1ed3b

[ghstack-poisoned]

pytorchmergebot added the merging label Jul 18, 2024

pytorchmergebot removed the merging label Jul 18, 2024

Resolve conflict

7ae8c1c

[ghstack-poisoned]

pytorchmergebot added the merging label Jul 18, 2024

pytorchmergebot removed the merging label Jul 18, 2024

pytorchmergebot added the merging label Jul 19, 2024

peterbell10 added a commit to peterbell10/pytorch that referenced this pull request Jul 22, 2024

[inductor] Kill mark_node_as_mutating

531ca70

Resubmit of pytorch#129346 ghstack-source-id: 498a08b Pull Request resolved: pytorch#130834

pytorchmergebot added a commit that referenced this pull request Jul 22, 2024

Revert "[inductor] Kill mark_node_as_mutating (#130834)"

f8875e8

This reverts commit 33f036a. Reverted #130834 on behalf of https://github.com/atalman due to broke periodic #130832 ([comment](#130834 (comment)))

pytorchmergebot added the Reverted label Jul 22, 2024

pytorchmergebot reopened this Jul 22, 2024

Update

218a50f

[ghstack-poisoned]

peterbell10 added the ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR label Jul 23, 2024

Update

cc1c273

[ghstack-poisoned]

peterbell10 added a commit to peterbell10/pytorch that referenced this pull request Jul 23, 2024

[inductor] Kill mark_node_as_mutating

3c7576f

Resubmit of pytorch#129346 ghstack-source-id: 0d8e6a9 Pull Request resolved: pytorch#130834

peterbell10 added 3 commits July 23, 2024 11:45

Update

cca69a1

[ghstack-poisoned]

Update

39e6e49

[ghstack-poisoned]

Update

0e173be

[ghstack-poisoned]

PaliC mentioned this pull request Jul 23, 2024

[BE] Improve error message when there are internal changes #131547

Closed

pytorchmergebot added the merging label Jul 24, 2024

pytorchmergebot closed this in 89d5391 Jul 24, 2024

pytorchmergebot removed the merging label Jul 24, 2024

Maykonlincoln pushed a commit to Maykonlincoln/Rede-neural that referenced this pull request Jul 25, 2024

[inductor] Kill mark_node_as_mutating

7e5a719

Resubmit of #129346 ghstack-source-id: 2737a81 Pull Request resolved: pytorch/pytorch#130834

henrylhtsang mentioned this pull request Jul 31, 2024

[BE][typing] fix types in common pruning #132309

Closed

github-actions bot deleted the gh/peterbell10/761/head branch August 24, 2024 01:57

[inductor] Kill mark_node_as_mutating #130834

[inductor] Kill mark_node_as_mutating #130834

Uh oh!

Conversation

peterbell10 commented Jul 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jul 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130834

✅ You can merge normally! (3 Unrelated Failures)

Uh oh!

peterbell10 commented Jul 18, 2024

Uh oh!

pytorchmergebot commented Jul 18, 2024

Merge started

Uh oh!

pytorchmergebot commented Jul 18, 2024

Merge failed

Uh oh!

peterbell10 commented Jul 18, 2024

Uh oh!

pytorchmergebot commented Jul 18, 2024

Merge started

Uh oh!

pytorchmergebot commented Jul 18, 2024

Uh oh!

peterbell10 commented Jul 18, 2024

Uh oh!

pytorchmergebot commented Jul 18, 2024

Merge started

Uh oh!

pytorchmergebot commented Jul 18, 2024

Merge failed

Uh oh!

peterbell10 commented Jul 18, 2024

Uh oh!

atalman commented Jul 22, 2024

Uh oh!

pytorchmergebot commented Jul 22, 2024

Uh oh!

pytorchmergebot commented Jul 22, 2024

Uh oh!

peterbell10 commented Jul 24, 2024

Uh oh!

pytorchmergebot commented Jul 24, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

peterbell10 commented Jul 16, 2024 •

edited

Loading

pytorch-bot bot commented Jul 16, 2024 •

edited

Loading