[export] constants & non-persistent buffers for training IR #130864
Conversation
pianpwk
requested review from
avikchaudhuri,
gmagogsfm,
tugsbayasgalan and
zhxchen17
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130864
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 50a8f96 with merge base d7a8e8f ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D59820909 |
torch/export/exported_program.py
Outdated
There was a problem hiding this comment.
This isn't needed at this point, _export_to_aten_ir() already runs this.
|
This pull request was exported from Phabricator. Differential Revision: D59820909 |
pianpwk
force-pushed
the
export-D59820909
branch
from
ba285dd to
ac6033b
Compare
facebook-github-bot
force-pushed
the
export-D59820909
branch
from
ac6033b to
313abd0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D59820909 |
Summary: Pull Request resolved: #130864 Uses original ExportedProgram constants and graph signature to inform decompositions, so that constant tensors and non-persistent buffers are respected for training IR. Removes 7 test failures for training IR. Test Plan: test_export Differential Revision: D59820909
|
This pull request was exported from Phabricator. Differential Revision: D59820909 |
pianpwk
force-pushed
the
export-D59820909
branch
from
313abd0 to
50a8f96
Compare
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: Uses original ExportedProgram constants and graph signature to inform decompositions, so that constant tensors and non-persistent buffers are respected for training IR. Removes 7 test failures for training IR. Test Plan: test_export Differential Revision: D59820909 Pull Request resolved: #130864 Approved by: https://github.com/angelayi
…130864) Summary: Uses original ExportedProgram constants and graph signature to inform decompositions, so that constant tensors and non-persistent buffers are respected for training IR. Removes 7 test failures for training IR. Test Plan: test_export Differential Revision: D59820909 Pull Request resolved: pytorch#130864 Approved by: https://github.com/angelayi
…130864) Summary: Uses original ExportedProgram constants and graph signature to inform decompositions, so that constant tensors and non-persistent buffers are respected for training IR. Removes 7 test failures for training IR. Test Plan: test_export Differential Revision: D59820909 Pull Request resolved: pytorch#130864 Approved by: https://github.com/angelayi
4 participants
Summary: Uses original ExportedProgram constants and graph signature to inform decompositions, so that constant tensors and non-persistent buffers are respected for training IR. Removes 7 test failures for training IR.
Test Plan: test_export
Differential Revision: D59820909