Make sure that TransformGetItemToIndex for all graph replay #131003
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/131003
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 007620b with merge base 90105a4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
[ghstack-poisoned]
drisspg
requested review from
albanD,
jbschlosser and
mikaylagawarecki
as code owners
| grad_scores, | ||
| torch.tensor(0, dtype=query.dtype), | ||
|
|
||
| mask_mod = _vmap_for_bhqkv( |
There was a problem hiding this comment.
Can you add a test that would catch this?
|
|
||
| @supported_platform | ||
| @common_utils.parametrize("mode", ["eager", "aot_eager"]) | ||
| def test_document_masking_edge_case(self, mode): |
There was a problem hiding this comment.
cc @Chillee verified this test would have caught, is that good?
There was a problem hiding this comment.
oh I see, it's running in 'eager' mode. Makes sense.
|
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot merge -f "queues are incredibly long" |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…131003) Pull Request resolved: pytorch#131003 Approved by: https://github.com/Chillee ghstack dependencies: pytorch#130871
…131003) Pull Request resolved: pytorch#131003 Approved by: https://github.com/Chillee ghstack dependencies: pytorch#130871
3 participants
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang