[c10d] add bfloat16 support for NAN check #131131
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Need another dispacher macro to support more data types Test Plan: (sqzhang_1) [sqzhang@devgpu009.cln1 ~/pytorch (86fcae11)]$ python test/distributed/test_c10d_nccl.py -k test_nan_assert_bfloat16 /home/sqzhang/pytorch/torch/csrc/distributed/c10d/Utils.cu:18: checkForNaN: block: [0,0,0], thread: [85,0,0] Assertion `!isnan(data[i])` failed. /home/sqzhang/pytorch/torch/csrc/distributed/c10d/Utils.cu:18: checkForNaN: block: [0,0,0], thread: [18,0,0] Assertion `!isnan(data[i])` failed. NCCL version 2.21.5+cuda12.0 devgpu009:1193787:1193787 [0] init.cc:1773 NCCL WARN Cuda failure 'device-side assert triggered' . ---------------------------------------------------------------------- Ran 1 test in 9.416s OK Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/131131
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fa482bf with merge base 8bf0be7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
oncall: distributed
Summary: Need another dispacher macro to support more data types Test Plan: (sqzhang_1) [sqzhangdevgpu009.cln1 ~/pytorch (86fcae11)]$ python test/distributed/test_c10d_nccl.py -k test_nan_assert_bfloat16 /home/sqzhang/pytorch/torch/csrc/distributed/c10d/Utils.cu:18: checkForNaN: block: [0,0,0], thread: [85,0,0] Assertion `!isnan(data[i])` failed. /home/sqzhang/pytorch/torch/csrc/distributed/c10d/Utils.cu:18: checkForNaN: block: [0,0,0], thread: [18,0,0] Assertion `!isnan(data[i])` failed. NCCL version 2.21.5+cuda12.0 devgpu009:1193787:1193787 [0] init.cc:1773 NCCL WARN Cuda failure 'device-side assert triggered' . ---------------------------------------------------------------------- Ran 1 test in 9.416s OK Reviewers: Subscribers: Tasks: Tags: cc XilunWu H-Huang awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o [ghstack-poisoned]
shuqiangzhang
added a commit
that referenced
this pull request
Jul 19, 2024
Summary: Need another dispacher macro to support more data types Test Plan: (sqzhang_1) [sqzhangdevgpu009.cln1 ~/pytorch (86fcae11)]$ python test/distributed/test_c10d_nccl.py -k test_nan_assert_bfloat16 /home/sqzhang/pytorch/torch/csrc/distributed/c10d/Utils.cu:18: checkForNaN: block: [0,0,0], thread: [85,0,0] Assertion `!isnan(data[i])` failed. /home/sqzhang/pytorch/torch/csrc/distributed/c10d/Utils.cu:18: checkForNaN: block: [0,0,0], thread: [18,0,0] Assertion `!isnan(data[i])` failed. NCCL version 2.21.5+cuda12.0 devgpu009:1193787:1193787 [0] init.cc:1773 NCCL WARN Cuda failure 'device-side assert triggered' . ---------------------------------------------------------------------- Ran 1 test in 9.416s OK Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: fbd550c Pull Request resolved: #131131
wconstab
approved these changes
Jul 19, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
XilunWu
approved these changes
Jul 19, 2024
|
@pytorchbot merge -f "all checks passed" |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
bigfootjon
pushed a commit
that referenced
this pull request
Jul 24, 2024
Summary: Need another dispacher macro to support more data types Test Plan: (sqzhang_1) [sqzhang@devgpu009.cln1 ~/pytorch (86fcae11)]$ python test/distributed/test_c10d_nccl.py -k test_nan_assert_bfloat16 /home/sqzhang/pytorch/torch/csrc/distributed/c10d/Utils.cu:18: checkForNaN: block: [0,0,0], thread: [85,0,0] Assertion `!isnan(data[i])` failed. /home/sqzhang/pytorch/torch/csrc/distributed/c10d/Utils.cu:18: checkForNaN: block: [0,0,0], thread: [18,0,0] Assertion `!isnan(data[i])` failed. NCCL version 2.21.5+cuda12.0 devgpu009:1193787:1193787 [0] init.cc:1773 NCCL WARN Cuda failure 'device-side assert triggered' . ---------------------------------------------------------------------- Ran 1 test in 9.416s OK Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: #131131 Approved by: https://github.com/wconstab, https://github.com/XilunWu (cherry picked from commit 406f510)
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Jul 25, 2024
Summary: Need another dispacher macro to support more data types Test Plan: (sqzhang_1) [sqzhang@devgpu009.cln1 ~/pytorch (86fcae11)]$ python test/distributed/test_c10d_nccl.py -k test_nan_assert_bfloat16 /home/sqzhang/pytorch/torch/csrc/distributed/c10d/Utils.cu:18: checkForNaN: block: [0,0,0], thread: [85,0,0] Assertion `!isnan(data[i])` failed. /home/sqzhang/pytorch/torch/csrc/distributed/c10d/Utils.cu:18: checkForNaN: block: [0,0,0], thread: [18,0,0] Assertion `!isnan(data[i])` failed. NCCL version 2.21.5+cuda12.0 devgpu009:1193787:1193787 [0] init.cc:1773 NCCL WARN Cuda failure 'device-side assert triggered' . ---------------------------------------------------------------------- Ran 1 test in 9.416s OK Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: pytorch#131131 Approved by: https://github.com/wconstab, https://github.com/XilunWu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Need another dispacher macro to support more data types
Test Plan:
(sqzhang_1) [sqzhang@devgpu009.cln1 ~/pytorch (86fcae11)]$ python
test/distributed/test_c10d_nccl.py -k test_nan_assert_bfloat16
/home/sqzhang/pytorch/torch/csrc/distributed/c10d/Utils.cu:18:
checkForNaN: block: [0,0,0], thread: [85,0,0] Assertion
!isnan(data[i])failed./home/sqzhang/pytorch/torch/csrc/distributed/c10d/Utils.cu:18:
checkForNaN: block: [0,0,0], thread: [18,0,0] Assertion
!isnan(data[i])failed.NCCL version 2.21.5+cuda12.0
devgpu009:1193787:1193787 [0] init.cc:1773 NCCL WARN Cuda failure
'device-side assert triggered'
.
Ran 1 test in 9.416s
OK
Reviewers:
Subscribers:
Tasks:
Tags:
cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o