[triton_op] fix autotuning #131363
Closed
[triton_op] fix autotuning #131363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was we were shoving SymInts into the constant_args side table. The root problem is that torch.fx.node.base_types, which we use to determine what can be put in the graph, doesn't actually have SymInt in it. This PR fixes base_types to include SymInt. Test Plan: - tests [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/131363
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 Cancelled Jobs, 1 Unrelated FailureAs of commit fe86609 with merge base 102d8e5 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zou3519
added a commit
that referenced
this pull request
Jul 22, 2024
The problem was we were shoving SymInts into the constant_args side table. The root problem is that torch.fx.node.base_types, which we use to determine what can be put in the graph, doesn't actually have SymInt in it. This PR fixes base_types to include SymInt. Test Plan: - tests ghstack-source-id: 3768c34 Pull Request resolved: #131363
zou3519
added
ciflow/inductor
ci-no-td
oulgen
approved these changes
Jul 23, 2024
|
@pytorchbot merge -f "lint looks unrelated?" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchmergebot revert -c ignoredsignal -m "This was a tricky one, but looking at the code it's the change to torch/fx/node.py that triggered the type violation errors. Reverting since this is now breaking trunk" |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@zou3519 your PR has been successfully reverted. |
pytorchmergebot
added a commit
that referenced
this pull request
Jul 23, 2024
This reverts commit 154f274. Reverted #131363 on behalf of https://github.com/ZainRizvi due to This was a tricky one, but looking at the code it's the change to torch/fx/node.py that triggered the type violation errors. Reverting since this is now breaking trunk ([comment](#131363 (comment)))
The problem was we were shoving SymInts into the constant_args side table. The root problem is that torch.fx.node.base_types, which we use to determine what can be put in the graph, doesn't actually have SymInt in it. This PR fixes base_types to include SymInt. Test Plan: - tests cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
zou3519
requested review from
justinchuby,
shubhambhokare1,
titaiwangms and
wschin
as code owners
zou3519
added a commit
that referenced
this pull request
Jul 23, 2024
The problem was we were shoving SymInts into the constant_args side table. The root problem is that torch.fx.node.base_types, which we use to determine what can be put in the graph, doesn't actually have SymInt in it. This PR fixes base_types to include SymInt. Test Plan: - tests ghstack-source-id: b5fbeaf Pull Request resolved: #131363
justinchuby
approved these changes
Jul 23, 2024
The problem was we were shoving SymInts into the constant_args side table. The root problem is that torch.fx.node.base_types, which we use to determine what can be put in the graph, doesn't actually have SymInt in it. This PR fixes base_types to include SymInt. Test Plan: - tests cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Jul 24, 2024
The problem was we were shoving SymInts into the constant_args side table. The root problem is that torch.fx.node.base_types, which we use to determine what can be put in the graph, doesn't actually have SymInt in it. This PR fixes base_types to include SymInt. Test Plan: - tests ghstack-source-id: 95ca95f Pull Request resolved: #131363
|
@pytorchbot merge -f "rocm infinite queue" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Jul 25, 2024
The problem was we were shoving SymInts into the constant_args side table. The root problem is that torch.fx.node.base_types, which we use to determine what can be put in the graph, doesn't actually have SymInt in it. This PR fixes base_types to include SymInt. Test Plan: - tests Pull Request resolved: pytorch#131363 Approved by: https://github.com/oulgen
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Jul 25, 2024
This reverts commit 154f274. Reverted pytorch#131363 on behalf of https://github.com/ZainRizvi due to This was a tricky one, but looking at the code it's the change to torch/fx/node.py that triggered the type violation errors. Reverting since this is now breaking trunk ([comment](pytorch#131363 (comment)))
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Jul 25, 2024
The problem was we were shoving SymInts into the constant_args side table. The root problem is that torch.fx.node.base_types, which we use to determine what can be put in the graph, doesn't actually have SymInt in it. This PR fixes base_types to include SymInt. Test Plan: - tests Pull Request resolved: pytorch#131363 Approved by: https://github.com/oulgen, https://github.com/justinchuby
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The problem was we were shoving SymInts into the constant_args side
table. The root problem is that torch.fx.node.base_types, which we use
to determine what can be put in the graph, doesn't actually have SymInt
in it. This PR fixes base_types to include SymInt.
Test Plan:
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang