Skip to content

Annotate graph.py #131400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Annotate graph.py #131400

wants to merge 6 commits into from

Conversation

eellison
Copy link
Contributor

@eellison eellison commented Jul 22, 2024 •
edited by pytorch-bot bot
Loading

@eellison
Annotate graph.py
f89ae3f 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 22, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/131400

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 63c69f9 with merge base f8f41dc (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@eellison eellison requested a review from shunting314 July 22, 2024 22:37
@eellison
Update on "Annotate graph.py"
ad2f0e4 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@eellison
Update on "Annotate graph.py"
492c31c 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@eellison
Update on "Annotate graph.py"
59b3e5d 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@eellison eellison added the topic: not user facing topic category label Jul 23, 2024
@eellison
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 23, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@eellison
Update on "Annotate graph.py"
2247adb 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@eellison
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@eellison
Update on "Annotate graph.py"
63c69f9 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
eellison added a commit that referenced this pull request Jul 23, 2024
@eellison
Annotate graph.py
63b2a52 
ghstack-source-id: 80b1f10
Pull Request resolved: #131400
@eellison
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@eellison
Copy link
Contributor Author

@pytorchbot merge -f "no rocm specific code changes"

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

aorenste added a commit that referenced this pull request Jul 23, 2024
@aorenste
Fix mypy errors introduced by #131400
2fa21bb 
[ghstack-poisoned]
aorenste added a commit that referenced this pull request Jul 23, 2024
@aorenste
Fix mypy errors introduced by #131400
6179dce 
ghstack-source-id: ba96cf3
Pull Request resolved: #131522
pytorchmergebot pushed a commit that referenced this pull request Jul 23, 2024
@aorenste @pytorchmergebot
Fix mypy errors introduced by #131400 (#131522)
e3ca4e7 
Pull Request resolved: #131522
Approved by: https://github.com/zou3519, https://github.com/eellison
@PaliC PaliC mentioned this pull request Jul 23, 2024
Closed
@eellison eellison mentioned this pull request Jul 24, 2024
Closed
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
@eellison @xuhancn
Annotate graph.py (pytorch#131400)
f3d0557 
Pull Request resolved: pytorch#131400
Approved by: https://github.com/shunting314
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
@aorenste @xuhancn
Fix mypy errors introduced by pytorch#131400 (pytorch#131522)
6a38111 
Pull Request resolved: pytorch#131522
Approved by: https://github.com/zou3519, https://github.com/eellison
@eellison eellison mentioned this pull request Jul 26, 2024
Closed
pytorchmergebot pushed a commit that referenced this pull request Jul 29, 2024
@eellison @pytorchmergebot
Add config option to skip autotuning conv (#131839)
3d4de8e 
requested internally bc for some models the conv templates are not very helpful

Pull Request resolved: #131839
Approved by: https://github.com/oulgen
ghstack dependencies: #131400
pytorchmergebot pushed a commit that referenced this pull request Jul 30, 2024
@eellison @pytorchmergebot
Add config option to skip autotuning conv (#131839)
9598c58 
requested internally bc for some models the conv templates are not very helpful

Pull Request resolved: #131839
Approved by: https://github.com/oulgen
ghstack dependencies: #131400
@henrylhtsang henrylhtsang mentioned this pull request Jul 31, 2024
Closed
@github-actions github-actions bot deleted the gh/eellison/673/head branch August 23, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shunting314 shunting314 shunting314 approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eellison @pytorchmergebot @shunting314