Skip to content

Conversation

zou3519
Copy link
Contributor

@zou3519 zou3519 commented Jul 23, 2024

Stack from ghstack (oldest at bottom):

torch.utils._pytree imports optree if it's available. Instead, we change
it to if it gets used. The motivation for this is better isolation.

Test Plan:

  • new tests

torch.utils._pytree imports optree if it's available. Instead, we change
it to if it gets used. The motivation for this is better isolation.

Test Plan:
- new tests

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jul 23, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/131478

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit bdef50d with merge base 406f510 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

zou3519 added a commit that referenced this pull request Jul 23, 2024
torch.utils._pytree imports optree if it's available. Instead, we change
it to if it gets used. The motivation for this is better isolation.

Test Plan:
- new tests

ghstack-source-id: 0b4c84d
Pull Request resolved: #131478
@zou3519 zou3519 added ciflow/trunk Trigger trunk jobs on your pull request ci-no-td Do not run TD on this PR labels Jul 23, 2024
@zou3519 zou3519 requested a review from albanD July 23, 2024 17:07
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking the time to fix this!

FYI @XuehaiPan

script = """
import sys
import torch
import torch.utils._pytree
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is imported by side effect by "import torch" so this is not needed today

@zou3519 zou3519 added the topic: not user facing topic category label Jul 24, 2024
@zou3519
Copy link
Contributor Author

zou3519 commented Jul 24, 2024

@pytorchbot merge -f "rocm infinite queue"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
torch.utils._pytree imports optree if it's available. Instead, we change
it to if it gets used. The motivation for this is better isolation.

Test Plan:
- new tests
Pull Request resolved: pytorch#131478
Approved by: https://github.com/albanD
@github-actions github-actions bot deleted the gh/zou3519/1032/head branch August 24, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td Do not run TD on this PR ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants