[dynamo] mirror training flag in OptimizedModule #131546
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/131546
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 9dc6bd5 with merge base cfb9cca ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
torch/_dynamo/eval_frame.py
Outdated
| def __getattribute__(self, name): | ||
| if name == "training": | ||
| return getattr(self._orig_mod, name) | ||
| return super().__getattribute__(name) | ||
|
|
There was a problem hiding this comment.
Perhaps:
| def __getattribute__(self, name): | |
| if name == "training": | |
| return getattr(self._orig_mod, name) | |
| return super().__getattribute__(name) | |
| @property | |
| def training(self): | |
| return self._orig_mod.training |
The prior method will add overhead on every single attribute access.
There was a problem hiding this comment.
Needs a little more work to get the setter working.
Fixes #122414. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
5 participants
Stack from ghstack (oldest at bottom):
Fixes #122414.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames