Skip to content

[ts_converter] Support prim::max and prim::if with multiple outputs #131593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[ts_converter] Support prim::max and prim::if with multiple outputs #131593

wants to merge 1 commit into from

Conversation

SherlockNoMad
Copy link
Contributor

Summary: As title.

Test Plan: test_converter.py

Reviewed By: angelayi

Differential Revision: D60147455

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 24, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/131593

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 0c78fd9 with merge base 5f3f14e (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60147455

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60147455

SherlockNoMad added a commit to SherlockNoMad/pytorch that referenced this pull request Jul 24, 2024
@SherlockNoMad @facebook-github-bot
[ts_converter] Support prim::max and prim::if with multiple outputs (p…
4117109 
…ytorch#131593)

Summary:
Pull Request resolved: pytorch#131593

As title.

Test Plan: test_converter.py

Reviewed By: angelayi

Differential Revision: D60147455
ydwu4
ydwu4 approved these changes Jul 24, 2024
View reviewed changes
test/export/test_converter.py
# torch.randn([1, 1, 1]).to(torch.float64),
# )[0], 1
# )

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe turn this into a parametrized test and merge these two tests?

Copy link
Contributor Author

@SherlockNoMad SherlockNoMad Jul 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I tried

jit.script() failed at func(x_len, y_len), where func is parametrized as [builtins.min, builtins.max]

I guess scripting doesn't support capturing callable type.

test/export/test_converter.py Outdated
M()(torch.tensor(False), torch.tensor(4)),
)

@unittest.skip('Wrong fx subgraph for cond, need to fix')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiashenC can take a look?

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 24, 2024
SherlockNoMad added a commit to SherlockNoMad/pytorch that referenced this pull request Jul 24, 2024
@SherlockNoMad @facebook-github-bot
[ts_converter] Support prim::max and prim::if with multiple outputs (p…
918718c 
…ytorch#131593)

Summary:
Pull Request resolved: pytorch#131593

As title.

Test Plan: test_converter.py

Reviewed By: ydwu4, angelayi

Differential Revision: D60147455
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60147455

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60147455

@SherlockNoMad @facebook-github-bot
[ts_converter] Support prim::max and prim::if with multiple outputs (p…
0c78fd9 
…ytorch#131593)

Summary:
Pull Request resolved: pytorch#131593

As title.

Test Plan: test_converter.py

Reviewed By: ydwu4, angelayi

Differential Revision: D60147455
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60147455

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@henrylhtsang henrylhtsang mentioned this pull request Jul 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ydwu4 ydwu4 ydwu4 approved these changes

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri avikchaudhuri is a code owner

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17 zhxchen17 is a code owner

@angelayi angelayi Awaiting requested review from angelayi angelayi is a code owner

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SherlockNoMad @facebook-github-bot @pytorchmergebot @ydwu4