Skip to content

[Fix]: prim::If with multiple outputs and input return directly #131779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Fix]: prim::If with multiple outputs and input return directly #131779

wants to merge 1 commit into from

Conversation

jiashenC
Copy link
Contributor

Issue

Test is not working for prim::Loop with multiple outputs. Additionally fix issue where input is directly returned, which is not supported by HigherOrderOp.

Test Plan

pytest test/export/test_converter.py -s -k test_convert_if_multiple_out

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 25, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/131779

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b083f51 with merge base e3513fb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jiashenC jiashenC requested a review from SherlockNoMad July 25, 2024 18:04
@jiashenC jiashenC added the topic: not user facing topic category label Jul 26, 2024
@facebook-github-bot
Copy link
Contributor

@jiashenC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jiashenC jiashenC force-pushed the fix_wrong_fx_graph_of_cond branch from 5ce92cc to 3bffcf7 Compare August 1, 2024 16:31
@facebook-github-bot
Copy link
Contributor

@jiashenC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jiashenC jiashenC force-pushed the fix_wrong_fx_graph_of_cond branch from 3bffcf7 to b596dfc Compare August 1, 2024 22:45
@facebook-github-bot
Copy link
Contributor

@jiashenC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jiashenC jiashenC force-pushed the fix_wrong_fx_graph_of_cond branch from b596dfc to 6cacd97 Compare August 2, 2024 05:14
@facebook-github-bot
Copy link
Contributor

@jiashenC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jiashenC jiashenC force-pushed the fix_wrong_fx_graph_of_cond branch from 6cacd97 to 91754fb Compare August 2, 2024 15:32
@facebook-github-bot
Copy link
Contributor

@jiashenC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jiashenC jiashenC force-pushed the fix_wrong_fx_graph_of_cond branch from 91754fb to cabcc5b Compare August 2, 2024 20:22
@facebook-github-bot
Copy link
Contributor

@jiashenC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jiashenC jiashenC force-pushed the fix_wrong_fx_graph_of_cond branch from cabcc5b to b083f51 Compare August 2, 2024 23:34
@facebook-github-bot
Copy link
Contributor

@jiashenC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the fix_wrong_fx_graph_of_cond branch September 3, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SherlockNoMad SherlockNoMad SherlockNoMad approved these changes

@angelayi angelayi angelayi approved these changes

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri avikchaudhuri is a code owner

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17 zhxchen17 is a code owner

@ydwu4 ydwu4 Awaiting requested review from ydwu4 ydwu4 is a code owner

Assignees

No one assigned

Labels

ciflow/inductor Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jiashenC @facebook-github-bot @pytorchmergebot @SherlockNoMad @angelayi