Skip to content

Conversation

xuhancn
Copy link
Collaborator

@xuhancn xuhancn commented Jul 29, 2024

Copy link

pytorch-bot bot commented Jul 29, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132025

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit aa73f23 with merge base 0738916 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@xuhancn xuhancn changed the title turn on enable_kernel_profile on Windows. [inductor] turn on enable_kernel_profile on Windows. Jul 29, 2024
@xuhancn xuhancn requested a review from jgong5 July 29, 2024 09:24
@xuhancn xuhancn marked this pull request as ready for review July 29, 2024 09:24
jgong5
jgong5 previously requested changes Jul 29, 2024
Copy link
Collaborator

@jgong5 jgong5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also turn on the test test_cpp_kernel_profile from test_cpu_repro.py?

@xuhancn
Copy link
Collaborator Author

xuhancn commented Jul 29, 2024

Can you also turn on the test test_cpp_kernel_profile from test_cpu_repro.py?

@jgong5 Done.

@xuhancn xuhancn requested a review from jgong5 July 29, 2024 15:32
@xuhancn xuhancn dismissed jgong5’s stale review July 29, 2024 15:33

Done, the request action.

@xuhancn xuhancn added module: windows Windows support for PyTorch ciflow/trunk Trigger trunk jobs on your pull request intel This tag is for PR from Intel labels Jul 29, 2024
@xuhancn xuhancn requested a review from jansel July 30, 2024 02:29
@xuhancn
Copy link
Collaborator Author

xuhancn commented Jul 30, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@xuhancn
Copy link
Collaborator Author

xuhancn commented Jul 30, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request intel This tag is for PR from Intel Merged module: inductor module: windows Windows support for PyTorch open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants