[pytorch][counters] DynamicCounter #132166
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132166
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9111e71 with merge base 1118c74 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D60464055 |
andriigrynenko
force-pushed
the
export-D60464055
branch
from
4a8328e to
725cab9
Compare
Summary: Implement a callback-based dynamic counter with pluggable backends. The backend API and integration is similar to WaitCounter. Note that this counter should only be used with C++ callbacks, since making it safe to be used for GIL-requiring callbacks would be pretty challenging and may defeat the whole purpose of this counter (since the duration of the callback can no longer be guaranteed). Test Plan: unit test Reviewed By: asiab4 Differential Revision: D60464055
|
This pull request was exported from Phabricator. Differential Revision: D60464055 |
Summary: Implement a callback-based dynamic counter with pluggable backends. The backend API and integration is similar to WaitCounter. Note that this counter should only be used with C++ callbacks, since making it safe to be used for GIL-requiring callbacks would be pretty challenging and may defeat the whole purpose of this counter (since the duration of the callback can no longer be guaranteed). Test Plan: unit test Reviewed By: asiab4 Differential Revision: D60464055
andriigrynenko
force-pushed
the
export-D60464055
branch
from
725cab9 to
f714b92
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60464055 |
Summary: Implement a callback-based dynamic counter with pluggable backends. The backend API and integration is similar to WaitCounter. Note that this counter should only be used with C++ callbacks, since making it safe to be used for GIL-requiring callbacks would be pretty challenging and may defeat the whole purpose of this counter (since the duration of the callback can no longer be guaranteed). Test Plan: unit test Reviewed By: asiab4 Differential Revision: D60464055
andriigrynenko
force-pushed
the
export-D60464055
branch
from
f714b92 to
5e22860
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60464055 |
Summary: Implement a callback-based dynamic counter with pluggable backends. The backend API and integration is similar to WaitCounter. Note that this counter should only be used with C++ callbacks, since making it safe to be used for GIL-requiring callbacks would be pretty challenging and may defeat the whole purpose of this counter (since the duration of the callback can no longer be guaranteed). Test Plan: unit test Reviewed By: asiab4 Differential Revision: D60464055
andriigrynenko
force-pushed
the
export-D60464055
branch
from
5e22860 to
9111e71
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60464055 |
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
4 participants
Summary:
Implement a callback-based dynamic counter with pluggable backends.
The backend API and integration is similar to WaitCounter. Note that this counter should only be used with C++ callbacks, since making it safe to be used for GIL-requiring callbacks would be pretty challenging and may defeat the whole purpose of this counter (since the duration of the callback can no longer be guaranteed).
Test Plan: unit test
Differential Revision: D60464055