Skip to content

Conversation

@H-Huang
Copy link
Member

@H-Huang H-Huang commented Jul 30, 2024

Stack from ghstack (oldest at bottom):

python test/distributed/pipelining/test_schedule_multiproc.py -k test_forward_only

cc @XilunWu @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132177

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 15931cf with merge base 19db4f6 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue labels Jul 30, 2024
@H-Huang H-Huang marked this pull request as draft July 30, 2024 21:02
@H-Huang H-Huang requested a review from lessw2020 July 30, 2024 21:03
python test/distributed/pipelining/test_schedule_multiproc.py -k test_forward_only

cc XilunWu awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o

[ghstack-poisoned]
H-Huang added a commit that referenced this pull request Jul 30, 2024
ghstack-source-id: c35bcc1
Pull Request resolved: #132177
Copy link
Contributor

@lessw2020 lessw2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks a ton for adding!

  • minor q on future test addition
  • linting errors are easy fixes


# Run
num_iters = 20
for _ in range(num_iters):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generic q - is there an easy way to verify that things looped successfully (i.e. seed value for rand and then confirm expected final values after 20 iters)?
right now the test confirms it ran w/o error, but maybe future test should also verify an expected output?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added a validation check at the end of the test to compare the pipelined output with a reference model.

@H-Huang H-Huang marked this pull request as ready for review July 31, 2024 21:51
`python test/distributed/pipelining/test_schedule_multiproc.py -k test_forward_only`

cc XilunWu awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o

[ghstack-poisoned]
@H-Huang H-Huang changed the title [draft] [PP] Forward only schedule [PP] Forward only schedule Jul 31, 2024
@H-Huang H-Huang added release notes: distributed (pipeline) release notes category module: pipelining Pipeline Parallelism labels Jul 31, 2024
`python test/distributed/pipelining/test_schedule_multiproc.py -k test_forward_only`

cc XilunWu awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o

[ghstack-poisoned]
H-Huang added a commit that referenced this pull request Jul 31, 2024
ghstack-source-id: 8bbec63
Pull Request resolved: #132177
@H-Huang
Copy link
Member Author

H-Huang commented Jul 31, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 31, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

`python test/distributed/pipelining/test_schedule_multiproc.py -k test_forward_only`

cc XilunWu awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o

[ghstack-poisoned]
H-Huang added a commit that referenced this pull request Aug 1, 2024
ghstack-source-id: f6b32f4
Pull Request resolved: #132177
@H-Huang
Copy link
Member Author

H-Huang commented Aug 1, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/H-Huang/134/head branch September 1, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: pipelining Pipeline Parallelism oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (pipeline) release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants