Skip to content

Refactor local autotune remote cache to make the code less error prone #132289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Refactor local autotune remote cache to make the code less error prone #132289

wants to merge 1 commit into from

Conversation

oulgen
Copy link
Contributor

@oulgen oulgen commented Jul 31, 2024 •
edited
Loading

@oulgen oulgen mentioned this pull request Jul 31, 2024
Closed
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 31, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132289

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (15 Unrelated Failures)

As of commit ecf6cf1 with merge base 2c7bd61 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

oulgen added a commit that referenced this pull request Jul 31, 2024
@oulgen
Refactor local autotune remote cache to make the code less error prone
766a14f 
Fixed #132241

ghstack-source-id: d63c7b1
Pull Request resolved: #132289
@oulgen oulgen requested review from aorenste and ezyang July 31, 2024 16:54
@oulgen oulgen added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Jul 31, 2024
aorenste
aorenste approved these changes Jul 31, 2024
View reviewed changes
torch/_inductor/runtime/triton_heuristics.py


class LocalAutotuneCache:
def get(self, filename):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

def get(self, filename: os.PathLike) -> Optional[object]:

torch/_inductor/runtime/triton_heuristics.py
return json.loads(fd.read())
return None

def put(self, filename, data):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

def put(self, filename: os.PathLike, data: object) -> None:

torch/_inductor/runtime/triton_heuristics.py
):
configs_hash = hash_configs(configs)

local_cache = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe these vars should be packed together in an object and the following code should be a separate function?

@oulgen
Copy link
Contributor Author

oulgen commented Jul 31, 2024

@oulgen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@oulgen
Copy link
Contributor Author

oulgen commented Jul 31, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 11 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@oulgen
Copy link
Contributor Author

oulgen commented Jul 31, 2024

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 15 checks: pull / linux-focal-py3.12-clang10 / test (default, 2, 4, amz2023.linux.2xlarge), pull / linux-focal-py3.12-clang10-experimental-split-build / test (default, 2, 3, amz2023.linux.2xlarge), pull / linux-jammy-py3.10-clang15-asan / test (default, 2, 6, amz2023.linux.4xlarge), pull / linux-focal-py3.8-clang10 / test (default, 2, 4, amz2023.linux.2xlarge), pull / linux-focal-py3.8-clang10 / test (crossref, 1, 2, amz2023.linux.2xlarge), pull / linux-focal-py3.11-clang10 / test (default, 2, 4, amz2023.linux.2xlarge), pull / linux-focal-py3.11-clang10 / test (crossref, 1, 2, amz2023.linux.2xlarge), pull / linux-jammy-py3.8-gcc11 / test (default, 2, 4, amz2023.linux.2xlarge), pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 2, 5, amz2023.linux.4xlarge.nvidia.gpu), pull / linux-focal-cuda12.1-py3.10-gcc9-experimental-split-build / test (default, 2, 5, amz2023.linux.4xlarge.nvidia.gpu), pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 2, 5, amz2023.linux.g5.4xlarge.nvidia.gpu), trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (nogpu_AVX512, 1, 1, amz2023.linux.2xlarge), trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (nogpu_NO_AVX2, 1, 1, amz2023.linux.2xlarge), trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (default, 2, 5, amz2023.linux.4xlarge.nvidia.gpu), trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 2, 5, amz2023.linux.g5.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 11 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@oulgen
Copy link
Contributor Author

oulgen commented Jul 31, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 11 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@oulgen
Copy link
Contributor Author

oulgen commented Jul 31, 2024

@pytorchbot merge -f "only unrelated failures"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/oulgen/108/head branch August 31, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aorenste aorenste aorenste approved these changes

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oulgen @pytorchmergebot @aorenste