Fixes issue with torch._dynamo.assume_constant_result with global functions #132431
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132431
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 50af706 with merge base 8aacbee ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
soulitzer
added
the
triaged
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
ping @angelayi what is the status on getting this reviewed? |
|
@pytorchbot merge |
|
Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra. |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
…he function is at the global scope
|
Successfully rebased |
pytorchmergebot
force-pushed
the
dynamo-fixes-1
branch
from
3ef07d1 to
dbcd162
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@matthewfl can you fix that lint error? |
|
@jansel I will take care of it |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 3 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…ctions (#132431) This PR fixes an issue with `torch._dynamo.assume_constant_result` causing global values to be overwritten. Currently `torch._dynamo.assume_constant_result` saves the constant result into a global variable derived from the name of the function. This causes that function to be overwritten in the global scope. This PR checks that the name is unique in the global scope as well, avoiding the issue of overriding the function. Pull Request resolved: #132431 Approved by: https://github.com/jansel
5 participants
This PR fixes an issue with
torch._dynamo.assume_constant_resultcausing global values to be overwritten.Currently
torch._dynamo.assume_constant_resultsaves the constant result into a global variable derived from the name of the function. This causes that function to be overwritten in the global scope. This PR checks that the name is unique in the global scope as well, avoiding the issue of overriding the function.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @rec