[BE] put "show_dispatch_trace()" print logic in .cpp file #132717
Conversation
I find myself occasionally trying to modify this to get additional debug. Recompiling takes forever after modifying these lines, because the .h file is depended on by a huge number of files. If we move this logic into a helper function and put it in the .cpp file, recompilation will be a lot faster when adding debug here. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132717
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9a1a1f6 with merge base 8705313 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
I find myself occasionally trying to modify this to get additional debug info. Recompiling takes forever after modifying these lines, because the .h file is depended on by a huge number of files. If we move this logic into a helper function and put it in the .cpp file, recompilation will be a lot faster when adding debug here. Differential Revision: [D60804331](https://our.internmc.facebook.com/intern/diff/D60804331) [ghstack-poisoned]
I find myself occasionally trying to modify this to get additional debug info. Recompiling takes forever after modifying these lines, because the .h file is depended on by a huge number of files. If we move this logic into a helper function and put it in the .cpp file, recompilation will be a lot faster when adding debug here. Differential Revision: [D60804331](https://our.internmc.facebook.com/intern/diff/D60804331) [ghstack-poisoned]
I find myself occasionally trying to modify this to get additional debug info. Recompiling takes forever after modifying these lines, because the .h file is depended on by a huge number of files. If we move this logic into a helper function and put it in the .cpp file, recompilation will be a lot faster when adding debug here. Differential Revision: [D60804331](https://our.internmc.facebook.com/intern/diff/D60804331) [ghstack-poisoned]
I find myself occasionally trying to modify this to get additional debug. Recompiling takes forever after modifying these lines, because the .h file is depended on by a huge number of files. If we move this logic into a helper function and put it in the .cpp file, recompilation will be a lot faster when adding debug here. ghstack-source-id: fc11af2 Pull Request resolved: #132717
|
@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
davidberard98
requested review from
YuqingJ,
bdhirsh,
eellison,
jbschlosser and
soulitzer
I find myself occasionally trying to modify this to get additional debug info. Recompiling takes forever after modifying these lines, because the .h file is depended on by a huge number of files. If we move this logic into a helper function and put it in the .cpp file, recompilation will be a lot faster when adding debug here. Tested with a local DEBUG=1 build (which is needed to use `TORCH_SHOW_DISPATCH_TRACE=1`) and verified basic sanity - i.e. it still prints `[call]`, etc. Differential Revision: [D60804331](https://our.internmc.facebook.com/intern/diff/D60804331) [ghstack-poisoned]
I find myself occasionally trying to modify this to get additional debug. Recompiling takes forever after modifying these lines, because the .h file is depended on by a huge number of files. If we move this logic into a helper function and put it in the .cpp file, recompilation will be a lot faster when adding debug here. ghstack-source-id: 7f4d2a3 Pull Request resolved: #132717
|
@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
out of curiosity, what do you usually add? (is it worth committing it?) |
|
@bdhirsh For a kernel that was being dispatched with a |
4 participants
Stack from ghstack (oldest at bottom):
I find myself occasionally trying to modify this to get additional debug info. Recompiling takes forever after modifying these lines, because the .h file is depended on by a huge number of files.
If we move this logic into a helper function and put it in the .cpp file, recompilation will be a lot faster when adding debug here.
Tested with a local DEBUG=1 build (which is needed to use
TORCH_SHOW_DISPATCH_TRACE=1) and verified basic sanity - i.e. it still prints[call], etc.Differential Revision: D60804331