Support new upsample in symbolic, caffe2 backend & caffe2 frontend #13272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
zrphercule has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@zrphercule has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zrphercule
changed the title
zrphercule
changed the title
|
@houseroad Any more comments? CI is green. |
houseroad
approved these changes
Nov 1, 2018
|
import and update the submodule internally? |
There was a problem hiding this comment.
@zrphercule has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@zrphercule has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…13272) Summary: We updated the description of upsample_op in onnx: onnx/onnx#1467 Therefore, we need to support the new upsample_op in caffe2-onnx backend as well. Pull Request resolved: #13272 Differential Revision: D12833656 fbshipit-source-id: d534b440b6ffbc1a8e91a573bcdefc31f3ef847f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We updated the description of upsample_op in onnx: onnx/onnx#1467
Therefore, we need to support the new upsample_op in caffe2-onnx backend as well.