Skip to content

Conversation

@mlazos
Copy link
Contributor

@mlazos mlazos commented Aug 6, 2024

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 6, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132726

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 639d03a with merge base 260c991 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
mlazos added a commit that referenced this pull request Aug 6, 2024
ghstack-source-id: 307d4c6
Pull Request resolved: #132726
@mlazos
Copy link
Contributor Author

mlazos commented Aug 6, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

if static_input_idxs is None:
static_input_idxs = []

static_inputs_log.debug("static input idxs compile_fx_inner: %s", static_input_idxs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get this in tlparse too? (it will probably make debugging why cudagraphs aren't running easier on internal stuff)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm not actually super familiar but I see some examples using trace_structured here https://github.com/pytorch/pytorch/blob/main/torch/_inductor/compile_fx.py#L728)

@github-actions github-actions bot deleted the gh/mlazos/62/head branch September 9, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants