-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Fix infinite recursion while walking to submodules #132763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix infinite recursion while walking to submodules #132763
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132763
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit caec667 with merge base 679cdf6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
is there no way to test this? |
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@pytorchbot revert -m "We need to now revert #132216 in OSS and there is a dependency on this pr" -c "weird" I'd recommend putting the contents of this pr into #132216 |
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit 063a45e. Reverted #132763 on behalf of https://github.com/PaliC due to We need to now revert #132216 in OSS and there is a dependency on this pr ([comment](#132763 (comment)))
@XuehaiPan your PR has been successfully reverted. |
Squashed into #132216. |
Fixes #132216 (comment)