Skip to content

Conversation

XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan requested review from PaliC and ezyang August 6, 2024 16:02
Copy link

pytorch-bot bot commented Aug 6, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132763

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit caec667 with merge base 679cdf6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ezyang
Copy link
Contributor

ezyang commented Aug 6, 2024

is there no way to test this?

@ezyang
Copy link
Contributor

ezyang commented Aug 6, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 6, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@ezyang ezyang added the topic: not user facing topic category label Aug 7, 2024
@ezyang
Copy link
Contributor

ezyang commented Aug 7, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@PaliC
Copy link
Contributor

PaliC commented Aug 7, 2024

@pytorchbot revert -m "We need to now revert #132216 in OSS and there is a dependency on this pr" -c "weird"

I'd recommend putting the contents of this pr into #132216

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Aug 7, 2024
This reverts commit 063a45e.

Reverted #132763 on behalf of https://github.com/PaliC due to We need to now revert #132216 in OSS and there is a dependency on this pr ([comment](#132763 (comment)))
@pytorchmergebot
Copy link
Collaborator

@XuehaiPan your PR has been successfully reverted.

@XuehaiPan
Copy link
Collaborator Author

Squashed into #132216.

@XuehaiPan XuehaiPan closed this Aug 8, 2024
@XuehaiPan XuehaiPan deleted the fix-infinite-recursion-sys-modules branch October 11, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source Reverted topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants