[test/profiler] Make test_profiler_pattern_matcher_json_report write … #133009
Conversation
…torchtidy_report.json to a tmpdir instead of CWD
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133009
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 92f7330 with merge base 9d5c85c ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zou3519
added
the
triaged
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 3, 5, amz2023.linux.g5.4xlarge.nvidia.gpu) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -f "failure looks unrelated" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
| try: | ||
| with open("./torchtidy_report.json") as f: | ||
|
|
||
| with tempfile.TemporaryDirectory() as tmpdir: |
There was a problem hiding this comment.
You might want to double check that this doesn't break windows tests as it has in the past: #132749 (comment)
There was a problem hiding this comment.
ah, good to know. From https://hud.pytorch.org/pr/133009 looks like the windows tests succeeded.
5 participants
Makes it possible to run
test/profiler/test_profiler.py#test_profiler_pattern_matcher_json_reporton CI environments where the test runner doesn't have write permissions to the current-working-directory.