Skip to content

Allow SymInt input for torch.fx reinplace pass #133178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Allow SymInt input for torch.fx reinplace pass #133178

wants to merge 1 commit into from

Conversation

YangQun1
Copy link
Contributor

Fixes #133176

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 11, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133178

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 93a951f with merge base d4b31f7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Aug 11, 2024
@YangQun1
Copy link
Contributor Author

cc @ezyang Hi, could anyone help to review this change?

@albanD albanD requested a review from ezyang August 12, 2024 17:30
@albanD albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 12, 2024
@ezyang
Copy link
Contributor

ezyang commented Aug 12, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 12, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable), trunk / macos-py3-arm64 / test (default, 3, 3, macos-m1-stable)

Details for Dev Infra team Raised by workflow job

@YangQun1
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased yq/fix-functional-metadata-prop onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout yq/fix-functional-metadata-prop && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the yq/fix-functional-metadata-prop branch from 9af4e14 to 93a951f Compare August 13, 2024 02:56
@ezyang
Copy link
Contributor

ezyang commented Aug 13, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

mryszt pushed a commit to HabanaAI/pytorch-fork that referenced this pull request Oct 14, 2024
@mryszt
Allow SymInt input for torch.fx reinplace pass (pytorch#133178)
814cc53 
Fixes pytorch#133176

Pull Request resolved: pytorch#133178
Approved by: https://github.com/ezyang

Change-Id: If33cacbc11909e4659f10f22ae30e628b1e15d4a
mryszt pushed a commit to HabanaAI/pytorch-fork that referenced this pull request Oct 14, 2024
@mryszt
Allow SymInt input for torch.fx reinplace pass (pytorch#133178)
5b18eff 
Fixes pytorch#133176

Pull Request resolved: pytorch#133178
Approved by: https://github.com/ezyang

Change-Id: If33cacbc11909e4659f10f22ae30e628b1e15d4a
aostrowski-hbn pushed a commit to HabanaAI/pytorch-fork that referenced this pull request Oct 16, 2024
@aostrowski-hbn
Allow SymInt input for torch.fx reinplace pass (pytorch#133178)
a328af7 
Fixes pytorch#133176

Pull Request resolved: pytorch#133178
Approved by: https://github.com/ezyang

Change-Id: If33cacbc11909e4659f10f22ae30e628b1e15d4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: fx release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[torch.fx] _FunctionalizationMetadataProp.propagate method can't use non-tensor args

5 participants

@YangQun1 @ezyang @pytorchmergebot @albanD @pytorchbot