Skip to content

Remove AMD restrictions on triton hashing #133616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove AMD restrictions on triton hashing #133616

wants to merge 1 commit into from

Conversation

@oulgen
Copy link
Contributor

@oulgen oulgen commented Aug 15, 2024

Summary: When we added these functions, AMD's triton checkout was very old, it appears to have caught up. Remove restrictions.

Test Plan: unit tests

Differential Revision: D61351473

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 15, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133616

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f7648e9 with merge base 1653f77 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61351473

@oulgen oulgen added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Aug 15, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61351473

oulgen added a commit that referenced this pull request Aug 15, 2024
@oulgen @facebook-github-bot
Remove AMD restrictions on triton hashing (#133616)
1e4a19b 
Summary:
Pull Request resolved: #133616

When we added these functions, AMD's triton checkout was very old, it appears to have caught up. Remove restrictions.

Test Plan: unit tests

Differential Revision: D61351473
nmacchioni
nmacchioni reviewed Aug 15, 2024
View reviewed changes
Copy link
Contributor

@nmacchioni nmacchioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should be good since we moved to upstream repo

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61351473

@oulgen @facebook-github-bot
Remove AMD restrictions on triton hashing (#133616)
f7648e9 
Summary:
Pull Request resolved: #133616

When we added these functions, AMD's triton checkout was very old, it appears to have caught up. Remove restrictions.

Test Plan: unit tests

Reviewed By: nmacchioni, mxz297

Differential Revision: D61351473
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61351473

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the export-D61351473 branch September 28, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxz297 mxz297 mxz297 approved these changes

@eellison eellison eellison approved these changes

@nmacchioni nmacchioni nmacchioni approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@oulgen @facebook-github-bot @pytorchmergebot @mxz297 @eellison @nmacchioni