Update pt2e numeric debugger to use node.meta["custom"] field #134040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: With #131912 we now have a "custom" field in node.meta that can be preserved in * copy/deepcopy * run_decompositions() * serialization * re-exporting So we refactored numeric debugger to use this. Test Plan: python test/test_quantization.py TestNumericDebugger Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134040
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b7ec501 with merge base bce0cab ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…eld" Summary: With #131912 we now have a "custom" field in node.meta that can be preserved in * copy/deepcopy * run_decompositions() * serialization * re-exporting So we refactored numeric debugger to use this. Test Plan: python test/test_quantization.py TestNumericDebugger Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…eld" Summary: With #131912 we now have a "custom" field in node.meta that can be preserved in * copy/deepcopy * run_decompositions() * serialization * re-exporting So we refactored numeric debugger to use this. Test Plan: python test/test_quantization.py TestNumericDebugger Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Aug 20, 2024
Summary: With #131912 we now have a "custom" field in node.meta that can be preserved in * copy/deepcopy * run_decompositions() * serialization * re-exporting So we refactored numeric debugger to use this. Test Plan: python test/test_quantization.py TestNumericDebugger Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: b6af5d0 Pull Request resolved: #134040
tarun292
approved these changes
Aug 26, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
jerryzh168
added a commit
that referenced
this pull request
Aug 29, 2024
Summary: This is a follow up of #134040 to fix the remaining tests that still breaks right now, I think we'd need to fix something in export Test Plan: python test/test_quantization -k TestNumericDebugger Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Sep 3, 2024
Summary: This is a follow up of #134040 to fix the remaining tests that still breaks right now, I think we'd need to fix something in export Test Plan: python test/test_quantization -k TestNumericDebugger Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
yiming0416
reviewed
Sep 4, 2024
| for node in graph_module.graph.nodes: | ||
| if node.op != "placeholder" and NUMERIC_DEBUG_HANDLE_KEY not in node.meta: | ||
| node.meta[NUMERIC_DEBUG_HANDLE_KEY] = unique_id | ||
| if node.op in ["output", "placehodler"]: |
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
…h#134040) Summary: With pytorch#131912 we now have a "custom" field in node.meta that can be preserved in * copy/deepcopy * run_decompositions() * serialization * re-exporting So we refactored numeric debugger to use this. Test Plan: python test/test_quantization.py TestNumericDebugger Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: pytorch#134040 Approved by: https://github.com/tarun292
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
With #131912 we now have a "custom" field in node.meta that can be preserved
in
So we refactored numeric debugger to use this.
Test Plan:
python test/test_quantization.py TestNumericDebugger
Reviewers:
Subscribers:
Tasks:
Tags: