Skip to content

Conversation

yanboliang
Copy link
Contributor

@yanboliang yanboliang commented Aug 21, 2024

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Aug 21, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134087

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 8a1c30c with merge base d2c6074 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

yanboliang added a commit that referenced this pull request Aug 21, 2024
@yanboliang yanboliang requested a review from zou3519 August 21, 2024 05:54
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's beef up the test and see if it works.

[ghstack-poisoned]
[ghstack-poisoned]
@yanboliang yanboliang requested a review from zou3519 August 27, 2024 04:49
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM, but I added suggestions for more test cases, please read.

[ghstack-poisoned]
@yanboliang yanboliang added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 27, 2024
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@yanboliang
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@yanboliang yanboliang deleted the gh/yanboliang/24/head branch August 28, 2024 16:46
enter-ctrl9 pushed a commit to enter-ctrl9/pytorch11 that referenced this pull request Sep 15, 2024
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants