[fp8 rowwise] Some clean-up #134224
Closed
[fp8 rowwise] Some clean-up #134224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134224
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 4c19925 with merge base aea1148 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Aug 22, 2024
drisspg
approved these changes
Aug 22, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 23, 2024
Pull Request resolved: #134225 Approved by: https://github.com/drisspg ghstack dependencies: #134223, #134224
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 23, 2024
It's likely a matter of opinion, but I find this new version to have less duplication, even if it might have more boilerplate. Pull Request resolved: #134226 Approved by: https://github.com/drisspg ghstack dependencies: #134223, #134224, #134225
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 23, 2024
Pull Request resolved: #134227 Approved by: https://github.com/drisspg, https://github.com/eqy ghstack dependencies: #134223, #134224, #134225, #134226
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 26, 2024
…ch#134225) Pull Request resolved: pytorch#134225 Approved by: https://github.com/drisspg ghstack dependencies: pytorch#134223, pytorch#134224
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 26, 2024
It's likely a matter of opinion, but I find this new version to have less duplication, even if it might have more boilerplate. Pull Request resolved: pytorch#134226 Approved by: https://github.com/drisspg ghstack dependencies: pytorch#134223, pytorch#134224, pytorch#134225
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 26, 2024
) Pull Request resolved: pytorch#134227 Approved by: https://github.com/drisspg, https://github.com/eqy ghstack dependencies: pytorch#134223, pytorch#134224, pytorch#134225, pytorch#134226
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):