Skip to content

[DTensor] Add pointwise ops strategy for aten.isinf, aten.isneginf, aten.isposinf #134699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[DTensor] Add pointwise ops strategy for aten.isinf, aten.isneginf, aten.isposinf #134699

wants to merge 1 commit into from

Conversation

wz337
Copy link
Contributor

@wz337 wz337 commented Aug 28, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 28, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134699

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f9aff83 with merge base 40de63b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor oncall: distributed Add this issue/PR to distributed oncall triage queue labels Aug 28, 2024
@facebook-github-bot
Copy link
Contributor

@wz337 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@wz337 wz337 marked this pull request as ready for review August 28, 2024 17:39
@facebook-github-bot
Copy link
Contributor

@wz337 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@wz337 wz337 changed the title [DTensor] Add isinf to pointwise ops [DTensor] Add pointwise ops strategy for aten.isinf.default Aug 28, 2024
@wz337 wz337 changed the title [DTensor] Add pointwise ops strategy for aten.isinf.default [DTensor] Add pointwise ops strategy for aten.isinf, aten.isneginf, aten.isposinf Aug 28, 2024
@wz337 wz337 requested review from XilunWu and tianyu-l August 28, 2024 18:57
@facebook-github-bot
Copy link
Contributor

@wz337 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@wz337
Copy link
Contributor Author

wz337 commented Aug 29, 2024

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 29, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@wz337 wz337 added topic: not user facing topic category module: dtensor distributed tensor tag labels Aug 29, 2024
@wz337
Copy link
Contributor Author

wz337 commented Aug 29, 2024

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@wz337 @Chao1Han
[DTensor] Add pointwise ops strategy for aten.isinf, aten.isneginf, a…
b72e82c 
…ten.isposinf (pytorch#134699)

Fixes #ISSUE_NUMBER

Need it for https://github.com/facebookresearch/optimizers/blob/main/distributed_shampoo/utils/shampoo_preconditioner_list.py#L671

Pull Request resolved: pytorch#134699
Approved by: https://github.com/tianyu-l
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianyu-l tianyu-l tianyu-l approved these changes

@XilunWu XilunWu Awaiting requested review from XilunWu

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dtensor distributed tensor tag oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wz337 @facebook-github-bot @pytorchmergebot @tianyu-l