Skip to content

[justknobs] Override __bool__ method #134799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[justknobs] Override __bool__ method #134799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/test_utils_internal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@ def test_justknob_config(self):
self.assertTrue(a.get())
a.set(False)
self.assertTrue(a.get())
with self.subTest("Checks __bool__"):
a = JustKnobsConfig(name="fake_name", default=False)
if a:
raise RuntimeError("Should not be true")
self.assertFalse(a)

def test_justknob_feature(self):
with self.subTest("OSS is True"):
Expand Down
3 changes: 3 additions & 0 deletions torch/_utils_internal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,9 @@ def __str__(self):
v = bool(self)
return f"JustknobsConfig(name={self.name}, env_name={self.env_name}, default={self.default} - evals_to={v})"

def __bool__(self):
return self.get()


def justknobs_feature(
name: Optional[str], config_value=None, env_name=None, default: bool = True
Expand Down