Skip to content

[AOTI] Fix assert_function call in cpu autotune template #135086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[AOTI] Fix assert_function call in cpu autotune template #135086

wants to merge 7 commits into from

Conversation

desertfire
Copy link
Contributor

@desertfire desertfire commented Sep 4, 2024 •
edited
Loading

@desertfire
[AOTI] Fix assert_function call in cpu autotune template
52f36f5 
Summary: In the ABI-compatible mode, assert_function should be AOTI_TORCH_CHECK.

[ghstack-poisoned]
@desertfire desertfire mentioned this pull request Sep 3, 2024
Closed
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135086

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e39c174 with merge base 67c7924 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@desertfire desertfire mentioned this pull request Sep 4, 2024
Closed
This was referenced Sep 4, 2024
Closed
Closed
Closed
@desertfire desertfire added the topic: not user facing topic category label Sep 4, 2024
@desertfire
Update on "[AOTI] Fix assert_function call in cpu autotune template"
57cffde 
Summary: In the ABI-compatible mode, assert_function should be AOTI_TORCH_CHECK.

[ghstack-poisoned]
@desertfire desertfire mentioned this pull request Sep 4, 2024
Closed
@desertfire
Update on "[AOTI] Fix assert_function call in cpu autotune template"
e640079 
Summary: In the ABI-compatible mode, assert_function should be AOTI_TORCH_CHECK.

[ghstack-poisoned]
@desertfire
Update
eb744fa 
[ghstack-poisoned]
desertfire
desertfire commented Sep 4, 2024
View reviewed changes
test/inductor/test_cpu_cpp_wrapper.py
] = test_torchinductor.TestFailure(("cpp_wrapper",), is_skip=False)
skip_list = [
"test_multihead_attention_cpu",
*[
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to the skip list and will be removed in the next PR

@desertfire
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 5, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@desertfire
Copy link
Contributor Author

@pytorchbot merge

@desertfire
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@izaitsevfb
Copy link
Contributor

@pytorchbot revert -m "breaks internal tests, see D62405818" -c ghfirst

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@desertfire your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Sep 10, 2024
@pytorchmergebot
Revert "[AOTI] Fix assert_function call in cpu autotune template (#13…
0a9d55d 
…5086)"

This reverts commit 16c3b8f.

Reverted #135086 on behalf of https://github.com/izaitsevfb due to breaks internal tests, see D62405818 ([comment](#135086 (comment)))
@desertfire
Update
e39c174 
[ghstack-poisoned]
desertfire added a commit that referenced this pull request Sep 12, 2024
@desertfire
[AOTI] Fix assert_function call in cpu autotune template
90bcad8 
Summary: In the ABI-compatible mode, assert_function should be AOTI_TORCH_CHECK.

ghstack-source-id: cd729bc
Pull Request resolved: #135086
@desertfire desertfire mentioned this pull request Sep 12, 2024
Closed
desertfire added a commit to desertfire/pytorch that referenced this pull request Sep 12, 2024
@desertfire @facebook-github-bot
[AOTI][reland] Fix assert_function call in cpu autotune template (pyt…
76ba4a9 
…orch#135920)

Summary:
Pull Request resolved: pytorch#135920

Reland pytorch#135086. In the ABI-compatible mode, assert_function should be AOTI_TORCH_CHECK.

Test Plan: CI

Differential Revision: D62500592
pytorchmergebot pushed a commit that referenced this pull request Sep 13, 2024
@desertfire @pytorchmergebot
[AOTI][reland] Fix assert_function call in cpu autotune template (#13…
ea2ecab 
…5920)

Summary: Reland #135086. In the ABI-compatible mode, assert_function should be AOTI_TORCH_CHECK.

Test Plan: CI

Differential Revision: D62500592

Pull Request resolved: #135920
Approved by: https://github.com/chenyang78
@desertfire desertfire closed this Sep 13, 2024
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@desertfire @Chao1Han
[AOTI] Fix assert_function call in cpu autotune template (pytorch#135086
3999312 
)

Summary: In the ABI-compatible mode, assert_function should be AOTI_TORCH_CHECK.

Pull Request resolved: pytorch#135086
Approved by: https://github.com/chenyang78, https://github.com/angelayi
ghstack dependencies: pytorch#134857
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@pytorchmergebot @Chao1Han
Revert "[AOTI] Fix assert_function call in cpu autotune template (pyt…
a135766 
…orch#135086)"

This reverts commit 16c3b8f.

Reverted pytorch#135086 on behalf of https://github.com/izaitsevfb due to breaks internal tests, see D62405818 ([comment](pytorch#135086 (comment)))
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@desertfire @Chao1Han
[AOTI][reland] Fix assert_function call in cpu autotune template (pyt…
fc90d77 
…orch#135920)

Summary: Reland pytorch#135086. In the ABI-compatible mode, assert_function should be AOTI_TORCH_CHECK.

Test Plan: CI

Differential Revision: D62500592

Pull Request resolved: pytorch#135920
Approved by: https://github.com/chenyang78
@chunyuan-w chunyuan-w mentioned this pull request Sep 25, 2024
Closed
@github-actions github-actions bot deleted the gh/desertfire/458/head branch October 14, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenyang78 chenyang78 chenyang78 approved these changes

@angelayi angelayi angelayi approved these changes

@jgong5 jgong5 Awaiting requested review from jgong5

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor Reverted topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@desertfire @pytorchmergebot @izaitsevfb @chenyang78 @angelayi