Skip to content

Deal with size oblivious before going into worker #135137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Deal with size oblivious before going into worker #135137

wants to merge 4 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Sep 4, 2024 •
edited
Loading

@ezyang
Update
260adec 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135137

Note: Links to docs will display an error until the docs builds have been completed.

❌ 91 Cancelled Jobs, 2 Unrelated Failures

As of commit c258e51 with merge base 44ec706 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor release notes: fx release notes category labels Sep 4, 2024
@ezyang ezyang mentioned this pull request Sep 4, 2024
Closed
@ezyang
Update
dedc6ba 
[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Sep 6, 2024
Closed
@ezyang ezyang added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Sep 6, 2024
@ezyang
Update
dfa1eb3 
[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Sep 6, 2024
Closed
@albanD albanD removed their request for review September 6, 2024 15:00
@ezyang ezyang mentioned this pull request Sep 8, 2024
Closed
isuruf pushed a commit to isuruf/pytorch that referenced this pull request Sep 23, 2024
@ezyang @isuruf
Deal with size oblivious before going into worker
f34218e 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: b09f00f
Pull Request resolved: pytorch#135137
@ezyang
Update
c258e51 
[ghstack-poisoned]
@ezyang ezyang requested a review from isuruf September 26, 2024 16:43
isuruf
isuruf approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@isuruf isuruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

pytorchmergebot pushed a commit that referenced this pull request Sep 27, 2024
@ezyang @pytorchmergebot
Don't uselessly recompute axiom dict every static eval call (#135429)
507c69e 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: #135429
Approved by: https://github.com/isuruf
ghstack dependencies: #135137
@ezyang
Copy link
Contributor Author

ezyang commented Sep 27, 2024

@pytorchbot revert -c nosignal -m "this is the one that actually broke main"

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Sep 27, 2024
@pytorchmergebot
Revert "Deal with size oblivious before going into worker (#135137)"
de159f0 
This reverts commit 285fa03.

Reverted #135137 on behalf of https://github.com/ezyang due to this is the one that actually broke main ([comment](#135137 (comment)))
@pytorchmergebot
Copy link
Collaborator

@ezyang your PR has been successfully reverted.

@ezyang
Copy link
Contributor Author

ezyang commented Sep 27, 2024

This is mostly useful for collecting axioms, and I guess does make perf worse, so let's can it.

@ezyang ezyang closed this Sep 27, 2024
injiiiiil pushed a commit to injiiiiil/654 that referenced this pull request Oct 1, 2024
@ezyang
Deal with size oblivious before going into worker
beeae4e 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: 4d361e2
Pull Request resolved: pytorch/pytorch#135137
injiiiiil pushed a commit to injiiiiil/654 that referenced this pull request Oct 1, 2024
@ezyang
Deal with size oblivious before going into worker
cbb2b07 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: b09f00f
Pull Request resolved: pytorch/pytorch#135137
@github-actions github-actions bot deleted the gh/ezyang/2914/head branch October 28, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isuruf isuruf isuruf approved these changes

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri

@Chillee Chillee Awaiting requested review from Chillee

@pianpwk pianpwk Awaiting requested review from pianpwk

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: fx release notes category Reverted topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ezyang @pytorchmergebot @isuruf