Skip to content

Conversation

yf225
Copy link
Contributor

@yf225 yf225 commented Nov 2, 2018

ASAN test timeout such as https://circleci.com/gh/pytorch/pytorch/165649?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link doesn't actually show where the timeout happened because of the bash output buffering. This PR turns off the buffering to better surface the error.

@yf225 yf225 requested a review from ezyang November 2, 2018 17:28
@yf225 yf225 force-pushed the circleci_unbuffer branch from 3f48817 to b08101d Compare November 2, 2018 18:04
@yf225 yf225 force-pushed the circleci_unbuffer branch 2 times, most recently from 3d956dc to 340206a Compare November 6, 2018 02:10
@yf225 yf225 force-pushed the circleci_unbuffer branch from 340206a to 8fb26b8 Compare November 6, 2018 02:22
@yf225 yf225 force-pushed the circleci_unbuffer branch from c3b6440 to e4dd33a Compare November 6, 2018 19:27
@yf225 yf225 force-pushed the circleci_unbuffer branch from e4dd33a to cf3e30c Compare November 6, 2018 19:38
@yf225 yf225 closed this Nov 7, 2018
@yf225 yf225 reopened this Nov 7, 2018
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants